Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 87d9a6b1f9f21b312f69c79b7b426a045263f418
https://github.com/WebKit/WebKit/commit/87d9a6b1f9f21b312f69c79b7b426a045263f418
Author: Ruthvik Konda <[email protected]>
Date: 2025-10-21 (Tue, 21 Oct 2025)
Changed paths:
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in
A Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeCommitBundle.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
M
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
Log Message:
-----------
Move activityStateChangeID from transaction scope to main frame scope in
CommitLayerTree
https://bugs.webkit.org/show_bug.cgi?id=301114
rdar://163054763
Reviewed by Matt Woodrow.
Right now RemoteLayerTreeDrawingAreaProxy::commitLayerTree currently receives a
Vector<std::pair<RemoteLayerTreeTransaction,
RemoteScrollingCoordinatorTransaction>>, one pair per root frame. However, some
aspects of the transaction are
scoped to the root frame. Some are scoped to the page. And some are scoped to
the main frame. We want to accordingly
introduce some separation/organization here to reduce duplication and
unnecessary isMainFrameProcessTransaction() checks.
This PR is the first of many that starts this organization/migration. In this
PR, we just move one member activityStateChangeID from
transaction scope to main frame scope. It gets accordingly removed from the
isMainFrameProcessTransaction() check
on UIProcess side.
No new functionality is added. This is a simple refactoring. Existing test
coverage is enough.
As a result, no new tests are added.
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeCommitBundle.h: Added.
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::activityStateChangeID const): Deleted.
(WebKit::RemoteLayerTreeTransaction::setActivityStateChangeID): Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTreeTransaction):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
Canonical link: https://commits.webkit.org/301885@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
