Title: [113513] trunk/Source/WebCore
- Revision
- 113513
- Author
- simon...@chromium.org
- Date
- 2012-04-06 15:53:20 -0700 (Fri, 06 Apr 2012)
Log Message
Roll out change to HTMLParserIdioms.cpp from 82857
https://bugs.webkit.org/show_bug.cgi?id=83402
Change 82857 causes a DCHECK on fast/forms/number/ValidityState-typeMismatch-number.html
Darin suggested we roll out this file here: https://bugs.webkit.org/show_bug.cgi?id=82857#c20
Unreviewed, rolling out change that broke tests.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (113512 => 113513)
--- trunk/Source/WebCore/ChangeLog 2012-04-06 22:49:11 UTC (rev 113512)
+++ trunk/Source/WebCore/ChangeLog 2012-04-06 22:53:20 UTC (rev 113513)
@@ -1,3 +1,17 @@
+2012-04-06 James Simonsen <simon...@chromium.org>
+
+ Roll out change to HTMLParserIdioms.cpp from 82857
+ https://bugs.webkit.org/show_bug.cgi?id=83402
+
+ Change 82857 causes a DCHECK on fast/forms/number/ValidityState-typeMismatch-number.html
+
+ Darin suggested we roll out this file here: https://bugs.webkit.org/show_bug.cgi?id=82857#c20
+
+ Unreviewed, rolling out change that broke tests.
+
+ * html/parser/HTMLParserIdioms.cpp:
+ (WebCore::parseToDoubleForNumberType):
+
2012-04-06 Ilya Sherman <isher...@chromium.org>
Allow site authors to override autofilled fields' colors.
Modified: trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp (113512 => 113513)
--- trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp 2012-04-06 22:49:11 UTC (rev 113512)
+++ trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp 2012-04-06 22:53:20 UTC (rev 113513)
@@ -79,8 +79,11 @@
double value = string.toDouble(&valid);
if (!valid)
return false;
- ASSERT(isfinite(value));
+ // NaN and infinity are considered valid by String::toDouble, but not valid here.
+ if (!isfinite(value))
+ return false;
+
// Numbers are considered finite IEEE 754 single-precision floating point values.
// See HTML5 2.5.4.3 `Real numbers.'
if (-std::numeric_limits<float>::max() > value || value > std::numeric_limits<float>::max())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
