Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cf37c23ad69cb407e17d9f132de8740e4ae7f54a
https://github.com/WebKit/WebKit/commit/cf37c23ad69cb407e17d9f132de8740e4ae7f54a
Author: Razvan Caliman <[email protected]>
Date: 2025-09-29 (Mon, 29 Sep 2025)
Changed paths:
M Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
M Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
M Source/WebInspectorUI/UserInterface/Views/DOMTreeElementPathComponent.js
M Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
Log Message:
-----------
Web Inspector: Rename WI.DOMTreeElement.prototype._elementCloseTag
https://bugs.webkit.org/show_bug.cgi?id=299519
rdar://161318308
Reviewed by Devin Rousso.
While investigating https://commits.webkit.org/300471@main, the naming of
`_elementCloseTag` proved confusing at times.
It is a boolean indicating whether the `WI.DOMTreeElement` represents the
closing tag of a DOM element.
There's a similarly named member, `_closeTagTreeElement`,
which references the actual element of the close tag in the DOM tree outline.
This patch renames `_elementCloseTag` to `isElementCloseTag`, renames the
public getter,
and uses the same name across all call sites to make it easier to track across
objects.
* Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype.get selectionPathComponents):
* Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.get isElementCloseTag):
(WI.DOMTreeElement.prototype.get expandedChildCount):
(WI.DOMTreeElement.prototype.showChildNode):
(WI.DOMTreeElement.prototype.onpopulate):
(WI.DOMTreeElement.prototype.updateChildren):
(WI.DOMTreeElement.prototype.insertChildElement):
(WI.DOMTreeElement.prototype._updateChildren):
(WI.DOMTreeElement.prototype.onexpand):
(WI.DOMTreeElement.prototype.oncollapse):
(WI.DOMTreeElement.prototype.ondblclick):
(WI.DOMTreeElement.prototype._startEditing):
(WI.DOMTreeElement.prototype._nodeTitleInfo):
(WI.DOMTreeElement.prototype._updatePseudoClassIndicator):
(WI.DOMTreeElement.prototype._createBadges):
(WI.DOMTreeElement.prototype.isCloseTag): Deleted.
* Source/WebInspectorUI/UserInterface/Views/DOMTreeElementPathComponent.js:
(WI.DOMTreeElementPathComponent.prototype.get nextSibling):
* Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype.update):
(WI.DOMTreeOutline.prototype.ondelete):
(WI.DOMTreeOutline.prototype.objectForSelection):
(WI.DOMTreeOutline.prototype._ondrop):
Canonical link: https://commits.webkit.org/300703@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
