Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a3704d355a10e3145b598af170faef8208175fc
https://github.com/WebKit/WebKit/commit/6a3704d355a10e3145b598af170faef8208175fc
Author: David Kilzer <[email protected]>
Date: 2025-10-10 (Fri, 10 Oct 2025)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushDaemonConnection.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushDaemonConnection.mm
Log Message:
-----------
_WKWebPushDaemonConnectionConfiguration leaks instance variables
<https://bugs.webkit.org/show_bug.cgi?id=300173>
<rdar://161958379>
Reviewed by Geoffrey Garen.
Regressed in 283218@main.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushDaemonConnection.h:
(_WKWebPushDaemonConnectionConfiguration.partition):
(_WKWebPushDaemonConnectionConfiguration.bundleIdentifierOverrideForTesting):
- Mark properties as `nullable` since the init method doesn't set them.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushDaemonConnection.mm:
(-[_WKWebPushDaemonConnectionConfiguration init]):
- Use setter to make sure `_machServiceName` is retained.
(-[_WKWebPushDaemonConnectionConfiguration dealloc]): Add.
- Release instance variables to fix leaks.
Canonical link: https://commits.webkit.org/301312@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
