Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ff7a5d0519dee14d53107f64e679fd281283926
https://github.com/WebKit/WebKit/commit/5ff7a5d0519dee14d53107f64e679fd281283926
Author: Chris Dumez <[email protected]>
Date: 2025-10-05 (Sun, 05 Oct 2025)
Changed paths:
M
Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/JavaScriptCore/bytecode/Watchpoint.h
Log Message:
-----------
Address safer cpp warnings in JSC::Watchpoint
https://bugs.webkit.org/show_bug.cgi?id=300156
Reviewed by Yusuke Suzuki.
This tested as performance neutral on JetStream.
Yusuke audit existing code and believes extending the lifetime of the
Watchpoint via RefPtr is safe:
1. JSGlobalObject fields. This is fine as it is destroyed via GC destructor
for JSGlobalObject. And GC destruction is not driven by some random C++
destructor calls.
2. FunctionRareData fields. This is safe as well as the same reason to (1)
3. StructureRareData fields. This is also safe. Boxed, but this is just
shared between StructureRareData.
4. Structure field. This is fine as the same reason.
5. Only problematic case looks like ArrayBuffer's field. But all possible
firing code for this InlinedWatchpoint is already keeping this
ArrayBuffer-refed. So this is also fine.
*
Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/JavaScriptCore/bytecode/Watchpoint.h:
(JSC::InlineWatchpointSet::startWatching):
(JSC::InlineWatchpointSet::fireAll):
(JSC::InlineWatchpointSet::invalidate):
(JSC::InlineWatchpointSet::touch):
(JSC::InlineWatchpointSet::protectedFat):
(JSC::InlineWatchpointSet::protectedFat const):
Canonical link: https://commits.webkit.org/301037@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
