Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fdc167276e9ebfdc8fba958391dfe422cefc72a6
https://github.com/WebKit/WebKit/commit/fdc167276e9ebfdc8fba958391dfe422cefc72a6
Author: Richard Robinson <[email protected]>
Date: 2025-10-06 (Mon, 06 Oct 2025)
Changed paths:
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Modules/MacCatalyst.modulemap
M Source/WebKit/Modules/OSX.modulemap
M Source/WebKit/Modules/iOS.modulemap
Log Message:
-----------
[Swift in WebKit] The WebKit module is not compatible with Objective-C++
clients
https://bugs.webkit.org/show_bug.cgi?id=300162
rdar://161943579
Reviewed by Abrar Rahman Protyasha.
The WebKit module maps currently use the `[extern_c]` annotation. Not only is
this
bad practice and should always be avoided, it is hazardous since it breaks the
module
for Objective-C++ clients. This is because when a client module is
Objective-C++, any
modules it uses are also considered (Objective-)C++ modules. Therefore,
including them
inside an `extern "c"` block results in a build error.
Fix by simply removing this annotation, since it serves no purpose as WebKit
already
uses `extern "c"` where applicable anyways.
* Source/WebKit/Configurations/WebKit.xcconfig:
Enable verification for Objective-C++ in addition to the default Objective-C
now that both pass.
Also use the "builtin" verifier for better performance and correctness.
* Source/WebKit/Modules/MacCatalyst.modulemap:
* Source/WebKit/Modules/OSX.modulemap:
* Source/WebKit/Modules/iOS.modulemap:
Remove [extern_c]
Canonical link: https://commits.webkit.org/301091@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
