Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b18ff101db00424e1d0c81442a55404c3a0e1ec3
https://github.com/WebKit/WebKit/commit/b18ff101db00424e1d0c81442a55404c3a0e1ec3
Author: Kimmo Kinnunen <[email protected]>
Date: 2025-09-24 (Wed, 24 Sep 2025)
Changed paths:
M Source/WebCore/platform/graphics/NativeImage.cpp
M Source/WebCore/platform/graphics/NativeImage.h
M Source/WebCore/platform/graphics/RenderingResource.h
M Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp
M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp
M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
R Source/WebKit/WebProcess/GPU/graphics/RemoteNativeImageBackendProxy.cpp
R Source/WebKit/WebProcess/GPU/graphics/RemoteNativeImageBackendProxy.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
GPUP: Remove RemoteNativeImageBackendProxy, it is not useful
https://bugs.webkit.org/show_bug.cgi?id=299282
rdar://problem/161086182
Reviewed by Matt Woodrow.
RemoteNativeImageBackendProxy, it was overly complex for what it did.
The shareable bitmap can be held in RemoteResourceCacheProxy
over GPUP restarts. Later on this state will be moved to shared resource
cache.
This prevents the code from having overly many remote related concepts.
Later commits will introduce distinct type of NativeImage,
RemoteNativeImageProxy, that enables NativeImages that do not
immediately read their contents to WCP.
* Source/WebCore/platform/graphics/NativeImage.cpp:
(WebCore::NativeImage::create):
(WebCore::NativeImage::NativeImage):
(WebCore::NativeImage::~NativeImage):
(WebCore::NativeImage::platformImage const):
(WebCore::NativeImage::replacePlatformImage):
(WebCore::NativeImageBackend::isRemoteNativeImageBackendProxy const): Deleted.
(WebCore::PlatformImageNativeImageBackend::platformImage const): Deleted.
(WebCore::PlatformImageNativeImageBackend::PlatformImageNativeImageBackend):
Deleted.
(WebCore::NativeImage::size const): Deleted.
(WebCore::NativeImage::hasAlpha const): Deleted.
(WebCore::NativeImage::colorSpace const): Deleted.
(WebCore::NativeImage::headroom const): Deleted.
(WebCore::NativeImage::replaceBackend): Deleted.
* Source/WebCore/platform/graphics/NativeImage.h:
(isType): Deleted.
* Source/WebCore/platform/graphics/RenderingResource.h:
(WebCore::RenderingResource::isNativeImage const): Deleted.
* Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::NativeImage::size const):
(WebCore::NativeImage::hasAlpha const):
(WebCore::NativeImage::colorSpace const):
(WebCore::NativeImage::headroom const):
(WebCore::PlatformImageNativeImageBackend::size const): Deleted.
(WebCore::PlatformImageNativeImageBackend::hasAlpha const): Deleted.
(WebCore::PlatformImageNativeImageBackend::colorSpace const): Deleted.
(WebCore::PlatformImageNativeImageBackend::headroom const): Deleted.
* Source/WebCore/platform/graphics/cg/NativeImageCG.cpp:
(WebCore::NativeImage::create):
(WebCore::NativeImage::size const):
(WebCore::NativeImage::hasAlpha const):
(WebCore::NativeImage::colorSpace const):
(WebCore::NativeImage::headroom const):
(WebCore::PlatformImageNativeImageBackend::size const): Deleted.
(WebCore::PlatformImageNativeImageBackend::hasAlpha const): Deleted.
(WebCore::PlatformImageNativeImageBackend::colorSpace const): Deleted.
(WebCore::PlatformImageNativeImageBackend::headroom const): Deleted.
* Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImage::size const):
(WebCore::NativeImage::hasAlpha const):
(WebCore::NativeImage::colorSpace const):
(WebCore::NativeImage::headroom const):
(WebCore::PlatformImageNativeImageBackend::size const): Deleted.
(WebCore::PlatformImageNativeImageBackend::hasAlpha const): Deleted.
(WebCore::PlatformImageNativeImageBackend::colorSpace const): Deleted.
(WebCore::PlatformImageNativeImageBackend::headroom const): Deleted.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/GPU/graphics/RemoteNativeImageBackendProxy.cpp:
Removed.
* Source/WebKit/WebProcess/GPU/graphics/RemoteNativeImageBackendProxy.h:
Removed.
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::didClose):
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::createShareableBitmapForNativeImage):
(WebKit::RemoteResourceCacheProxy::recordNativeImageUse):
(WebKit::RemoteResourceCacheProxy::willDestroyNativeImage):
(WebKit::RemoteResourceCacheProxy::disconnect):
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
Canonical link: https://commits.webkit.org/300463@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
