Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8dcaa756107b725c38efc50175abc8f6b01e6750
https://github.com/WebKit/WebKit/commit/8dcaa756107b725c38efc50175abc8f6b01e6750
Author: Alex Christensen <[email protected]>
Date: 2025-09-19 (Fri, 19 Sep 2025)
Changed paths:
M Source/WebKit/Shared/RemoteWorkerInitializationData.h
M Source/WebKit/Shared/RemoteWorkerInitializationData.serialization.in
M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp
M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
M
Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp
M Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp
M Source/WebKit/WebProcess/UserContent/WebUserContentController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Make WebUserContentController creation consistently apply all properties
https://bugs.webkit.org/show_bug.cgi?id=299135
rdar://160893408
Reviewed by Ryosuke Niwa.
Before this PR, we called WebUserContentController::getOrCreate then populated
its fields with whatever parameters we happened to have, which leads to
inconsistently
initialized WebUserContentControllers. This passes all needed parameters to
WebUserContentController::getOrCreate, and it will return the object if it
exists, or it will fully populate the object if it doesn't. This makes it so
all processes get the same representation of the WebUserContentControllerProxy.
I also replace WebUserContentControllerProxy::addProcess with the
WebUserContentControllerProxy keeping track of which processes it has
sent its parameters to, like we do in ContentWorld::worldDataForProcess.
* Source/WebKit/Shared/RemoteWorkerInitializationData.h:
* Source/WebKit/Shared/RemoteWorkerInitializationData.serialization.in:
* Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::parametersForProcess const):
(WebKit::WebUserContentControllerProxy::addProcess): Deleted.
* Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::userContentControllerForRemoteWorkers):
(WebKit::WebProcessPool::userContentControllerIdentifierForRemoteWorkers):
Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createForRemoteWorkers):
(WebKit::WebProcessProxy::enableRemoteWorkers):
(WebKit::contentRuleListsFromIdentifier): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::m_queue):
* Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
(WebKit::m_userContentController):
* Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::getOrCreate):
(WebKit::WebUserContentController::addUserStyleSheets):
(WebKit::WebUserContentController::addUserScriptMessageHandlers):
* Source/WebKit/WebProcess/UserContent/WebUserContentController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_toolbarsAreVisible):
Canonical link: https://commits.webkit.org/300243@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
