Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 27ebefc6f80d92f5e938e92ebd585712bb657f2f
https://github.com/WebKit/WebKit/commit/27ebefc6f80d92f5e938e92ebd585712bb657f2f
Author: Franco Vieira de Souza <[email protected]>
Date: 2025-09-18 (Thu, 18 Sep 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-keypress-expected.txt
M Source/WebCore/dom/KeyboardEvent.cpp
M Source/WebCore/dom/KeyboardEvent.h
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/platform/PlatformKeyboardEvent.h
M Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp
M Source/WebCore/platform/ios/KeyEventIOS.mm
M Source/WebCore/platform/libwpe/PlatformKeyboardEventLibWPE.cpp
M Source/WebCore/platform/mac/KeyEventMac.mm
M Source/WebCore/platform/win/KeyEventWin.cpp
M Source/WebKit/Shared/WebKeyboardEvent.h
M Source/WebKit/Shared/win/WebEventFactory.cpp
M Source/WebKit/UIProcess/win/WebPageProxyWin.cpp
Log Message:
-----------
Event Timing: assign interactionID to keypress
https://bugs.webkit.org/show_bug.cgi?id=298904
rdar://160647204
Reviewed by Ryosuke Niwa.
Assigns an interactionID to keypress events when they are
part of a keydown-keypress sequence. This is not in
accordance to the event timing spec, but is required by
one WPT test (event-timing/interactionid-keypress.html).
Implementing this required deferring the dispatch of keypress
events until the keyup event happens, in a similar manner to
what was already happening for keydown (see the change on
m_pendingKeyDowns).
Matching a keypress to a keydown required an extra function
(KeyboardEvent::keyCodeForKeyDown()) and some change in logic
because the keyCode of keypresses is normally overridden. We now
preserve the original value and do the overriding in
windowsVirtualKeyCode().
Now passing:
*
LayoutTests/imported/w3c/web-platform-tests/event-timing/interactionid-keypress.html
Canonical link: https://commits.webkit.org/300198@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
