Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 23fb371328cf3c54930b21696a19a8f9acda0056
https://github.com/WebKit/WebKit/commit/23fb371328cf3c54930b21696a19a8f9acda0056
Author: Jamie Murphy <[email protected]>
Date: 2025-09-16 (Tue, 16 Sep 2025)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
Log Message:
-----------
Port WebExtensionContext Permissions to C++
https://bugs.webkit.org/show_bug.cgi?id=298204
Reviewed by Timothy Hatcher.
Moves and updates permission code to C++, and creates a new enum to specify
notifications, allowing for most functions to not worry about how notifications
will be handled per-platform, with the exception of functions emitting
notifications via the platform-specific system such as NSNotificationCenter.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::permissionNotification):
(WebKit::WebExtensionContext::permissionsDidChange):
(WebKit::WebExtensionContext::hasPermissionToSendWebRequestEvent):
(WebKit::WebExtensionContext::addItemsToContextMenu):
(WebKit::WebExtensionContext::userGesturePerformed):
(WebKit::WebExtensionContext::clearUserGesture):
(WebKit::WebExtensionContext::webViewConfiguration):
(WebKit::WebExtensionContext::loadDeclarativeNetRequestRules):
(WebKit::WebExtensionContext::handleContentRuleListMatchedRule):
(WebKit::WebExtensionContext::handleContentRuleListNotificationForTab):
(WebKit::WebExtensionContext::quotaForStorageType):
(WebKit::WebExtensionContext::grantedPermissions): Deleted.
(WebKit::WebExtensionContext::setGrantedPermissions): Deleted.
(WebKit::WebExtensionContext::deniedPermissions): Deleted.
(WebKit::WebExtensionContext::setDeniedPermissions): Deleted.
(WebKit::WebExtensionContext::grantedPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::setGrantedPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::deniedPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::setDeniedPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::grantPermissions): Deleted.
(WebKit::WebExtensionContext::denyPermissions): Deleted.
(WebKit::WebExtensionContext::grantPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::denyPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::removeGrantedPermissions): Deleted.
(WebKit::WebExtensionContext::removeGrantedPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::removeDeniedPermissions): Deleted.
(WebKit::WebExtensionContext::removeDeniedPermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::removePermissions): Deleted.
(WebKit::WebExtensionContext::removePermissionMatchPatterns): Deleted.
(WebKit::WebExtensionContext::removeExpired): Deleted.
(WebKit::WebExtensionContext::needsPermission): Deleted.
(WebKit::WebExtensionContext::hasPermission): Deleted.
(WebKit::WebExtensionContext::hasPermissions): Deleted.
(WebKit::WebExtensionContext::permissionState): Deleted.
(WebKit::WebExtensionContext::setPermissionState): Deleted.
(WebKit::WebExtensionContext::clearCachedPermissionStates): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp:
(WebKit::WebExtensionContext::grantedPermissions):
(WebKit::WebExtensionContext::setGrantedPermissions):
(WebKit::WebExtensionContext::deniedPermissions):
(WebKit::WebExtensionContext::setDeniedPermissions):
(WebKit::WebExtensionContext::grantedPermissionMatchPatterns):
(WebKit::WebExtensionContext::setGrantedPermissionMatchPatterns):
(WebKit::WebExtensionContext::setDeniedPermissionMatchPatterns):
(WebKit::WebExtensionContext::deniedPermissionMatchPatterns):
(WebKit::WebExtensionContext::grantPermissions):
(WebKit::WebExtensionContext::denyPermissions):
(WebKit::WebExtensionContext::grantPermissionMatchPatterns):
(WebKit::WebExtensionContext::denyPermissionMatchPatterns):
(WebKit::WebExtensionContext::removePermissions):
(WebKit::WebExtensionContext::removePermissionMatchPatterns):
(WebKit::WebExtensionContext::removeGrantedPermissionMatchPatterns):
(WebKit::WebExtensionContext::removeGrantedPermissions):
(WebKit::WebExtensionContext::removeDeniedPermissions):
(WebKit::WebExtensionContext::removeDeniedPermissionMatchPatterns):
(WebKit::WebExtensionContext::removeExpired):
(WebKit::WebExtensionContext::needsPermission):
(WebKit::WebExtensionContext::hasPermission):
(WebKit::WebExtensionContext::hasPermissions):
(WebKit::WebExtensionContext::permissionState):
(WebKit::WebExtensionContext::setPermissionState):
(WebKit::WebExtensionContext::clearCachedPermissionStates):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
Canonical link: https://commits.webkit.org/300065@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes