Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a02340881d478e5c443896f50e372edb48ad074
https://github.com/WebKit/WebKit/commit/5a02340881d478e5c443896f50e372edb48ad074
Author: Ahmad Saleem <[email protected]>
Date: 2025-09-16 (Tue, 16 Sep 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-group-001-expected.txt
M
LayoutTests/platform/glib/tables/mozilla_expected_failures/other/test4-expected.txt
M
LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableSection.cpp
Log Message:
-----------
[css-tables] Stop row collapsing from subtracting border spacing twice
https://bugs.webkit.org/show_bug.cgi?id=298828
rdar://160542118
Reviewed by Alan Baradlay.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge:
https://chromium.googlesource.com/chromium/src.git/+/a5f185d1c5985029f448f1f90dc633eb43196116
A collapsed row would subtract border-spacing right away, then also
subtract it later when passing heights to %-height children.
Unlike Blink's approach, I added 'rowHasVisibilityCollapse' as lambda,
in future, if we leverage it across other functions, we can change it
into helper function.
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-group-001-expected.txt:
Progressions
> Rebaselines:
*
LayoutTests/platform/glib/tables/mozilla_expected_failures/other/test4-expected.txt:
*
LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt:
*
LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
Canonical link: https://commits.webkit.org/300023@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
