Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d4c256af46387fe6ffb9119c724407b38fc67fef
https://github.com/WebKit/WebKit/commit/d4c256af46387fe6ffb9119c724407b38fc67fef
Author: Yulun Wu <[email protected]>
Date: 2025-09-13 (Sat, 13 Sep 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-justify-baseline-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-justify-baseline-003-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-justify-baseline-004-expected.txt
M Source/WebCore/rendering/RenderGrid.cpp
Log Message:
-----------
[Grid][Baseline] Fix RowAxisPositioning for baseline alignment in grid layout.
https://bugs.webkit.org/show_bug.cgi?id=296058
<rdar://155967278>
Reviewed by Sammy Gill.
This PR fixes 9 WPTs by adding first-baseline and last-baseline row axis
alignment to grid items.
Per:
https://www.w3.org/TR/css-align-3/#baseline-values
`The fallback alignment for first baseline is safe self-start (for
self-alignment)
or safe start (for content-distribution).
The fallback alignment for last baseline is safe self-end (for self-alignment)
or safe end (for content-distribution).`
This PR also handles opposite flow grid items to resolve to the
correct physical direction for different writing modes.
This PR also fixes an issue where rowAxisOffsetForGridItem() failed
to account for rowAxisBaselineOffset when determining the offset for
GridAxisEnd items.
Note that non-inline matching orthogonal grid items are not handled properly.
We are defaulting back to the previous broken behavior as many WPTs are
currently
dependendent on that broken behavior to pass.
Combined changes:
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-justify-baseline-002-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-justify-baseline-003-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-justify-baseline-004-expected.txt:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::rowAxisPositionForGridItem const):
(WebCore::RenderGrid::columnAxisOffsetForGridItem const):
(WebCore::RenderGrid::rowAxisOffsetForGridItem const):
Canonical link: https://commits.webkit.org/299933@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
