Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: adddeadab02a659a7217801e5095fc08d994a4b0
https://github.com/WebKit/WebKit/commit/adddeadab02a659a7217801e5095fc08d994a4b0
Author: Vitor Roriz <[email protected]>
Date: 2025-09-11 (Thu, 11 Sep 2025)
Changed paths:
A
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-1-expected.html
A
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-1.html
A
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-2-expected.html
A
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-2.html
A
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-3-expected.html
A
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-3.html
M LayoutTests/platform/win/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/css/html.css
M Source/WebCore/rendering/TextBoxPainter.cpp
Log Message:
-----------
Paint text-decoration-line: spelling-error
https://bugs.webkit.org/show_bug.cgi?id=297412
rdar://158343332
Reviewed by Aditya Keerthi.
- Paint spelling-error decoration for an element which effective
text-decoration-line
(textDecorationLineInEffect) style is set to 'spelling-error'
- SpellingError marked text that is styled via ::spelling-error is removed from
being
painted as a marker, such that it is painted as regular text-decoration
(TextDecorationPainter),
honoring the style set, unless its text-decoration-line is spelling-error
itself.
In the latter case we should paint decoration with our native spelling error
markers.
*
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-1-expected.html:
Added.
* LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-1.html:
Added.
*
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-2-expected.html:
Added.
* LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-2.html:
Added.
*
LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-3-expected.html:
Added.
* LayoutTests/css3/text-decoration/text-decoration-line-spelling-error-3.html:
Added.
* LayoutTests/platform/win/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/css/html.css:
(:root::spelling-error):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::removeMarkersPaintedByTextDecorationPainter):
(WebCore::markedTextForTextDecorationLine):
(WebCore::TextBoxPainter::paintPlatformDocumentMarkers):
Canonical link: https://commits.webkit.org/299864@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
