Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f6b6bea2079964f2f70dd12df7f4b7fbc335aa2
      
https://github.com/WebKit/WebKit/commit/1f6b6bea2079964f2f70dd12df7f4b7fbc335aa2
  Author: peter <[email protected]>
  Date:   2025-09-09 (Tue, 09 Sep 2025)

  Changed paths:
    A LayoutTests/fast/dom/gc-abort-controller-expected.txt
    A LayoutTests/fast/dom/gc-abort-controller.html
    M Source/WebCore/bindings/js/JSAbortSignalCustom.cpp

  Log Message:
  -----------
  Fix AbortController memory leak with event

https://bugs.webkit.org/show_bug.cgi?id=298499

Reviewed by Ryosuke Niwa.

AbortSignals with event listeners were never garbage collected due to incorrect 
reachability check in JSAbortSignalOwner::isReachableFromOpaqueRoots().
The method unconditionally returned true for signals with event listeners, even 
when they had no other references.

Changed the logic to check containsWebCoreOpaqueRoot() before marking the 
signal as reachable, allowing proper garbage collection.

* LayoutTests/fast/dom/gc-abort-controller-expected.txt: Added.
* LayoutTests/fast/dom/gc-abort-controller.html: Added.
* Source/WebCore/bindings/js/JSAbortSignalCustom.cpp:
(WebCore::JSAbortSignalOwner::isReachableFromOpaqueRoots):

Canonical link: https://commits.webkit.org/299758@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to