Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8a02331ca45d6bed34882b7e7a78bcca50769af3
https://github.com/WebKit/WebKit/commit/8a02331ca45d6bed34882b7e7a78bcca50769af3
Author: Joshua Hoffman <[email protected]>
Date: 2025-09-05 (Fri, 05 Sep 2025)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AXObjectRareData.h
M Source/WebCore/accessibility/AXTableHelpers.cpp
M Source/WebCore/accessibility/AXTableHelpers.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
R Source/WebCore/accessibility/AccessibilityTableCell.cpp
R Source/WebCore/accessibility/AccessibilityTableCell.h
M Source/WebCore/accessibility/AccessibilityTree.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: Collapse AccessibilityTableCell into AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=298417
rdar://159890500
Reviewed by Tyler Wilcock.
Collapses all of the logic from AccessibilityTableCell into
AccessibilityRenderObject
and AccessibilityNodeObject as appropriate.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::hasCellOrRowRole const):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::AXLogger::log):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::createObjectFromRenderer):
(WebCore::AXObjectCache::createFromNode):
(WebCore::AXObjectCache::handleRowspanChanged):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::deferRowspanChange):
(WebCore::isAccessibilityTableCell): Deleted.
(WebCore::isAccessibilityARIAGridCell): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AXObjectRareData.h:
(WebCore::AXObjectRareData::columnIndex const):
(WebCore::AXObjectRareData::setColumnIndex):
(WebCore::AXObjectRareData::axColIndexFromRow const):
(WebCore::AXObjectRareData::setAXColIndexFromRow):
(WebCore::AXObjectRareData::effectiveRowSpan const):
(WebCore::AXObjectRareData::incrementEffectiveRowSpan):
(WebCore::AXObjectRareData::resetEffectiveRowSpan):
* Source/WebCore/accessibility/AXTableHelpers.cpp:
(WebCore::AXTableHelpers::isTableCellElement):
* Source/WebCore/accessibility/AXTableHelpers.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::computeIsIgnored const):
(WebCore::AccessibilityNodeObject::rowHeaders):
(WebCore::AccessibilityNodeObject::computeCellSlots):
(WebCore::AccessibilityNodeObject::parentTable const):
(WebCore::AccessibilityNodeObject::setRowIndex):
(WebCore::AccessibilityNodeObject::axColumnIndex const):
(WebCore::AccessibilityNodeObject::axRowIndex const):
(WebCore::AccessibilityNodeObject::axRowIndexText const):
(WebCore::AccessibilityNodeObject::isTableCell const):
(WebCore::AccessibilityNodeObject::isARIAGridCell const):
(WebCore::AccessibilityNodeObject::isExposedTableCell const):
(WebCore::AccessibilityNodeObject::parentTableIfTableCell const):
(WebCore::AccessibilityNodeObject::isTableHeaderCell const):
(WebCore::AccessibilityNodeObject::isColumnHeader const):
(WebCore::AccessibilityNodeObject::isRowHeader const):
(WebCore::AccessibilityNodeObject::rowIndexRange const):
(WebCore::AccessibilityNodeObject::columnIndexRange const):
(WebCore::AccessibilityNodeObject::axColumnIndexText const):
(WebCore::AccessibilityNodeObject::colSpan const):
(WebCore::AccessibilityNodeObject::rowSpan const):
(WebCore::AccessibilityNodeObject::incrementEffectiveRowSpan):
(WebCore::AccessibilityNodeObject::resetEffectiveRowSpan):
(WebCore::AccessibilityNodeObject::setAXColIndexFromRow):
(WebCore::AccessibilityNodeObject::setColumnIndex):
(WebCore::AccessibilityNodeObject::parentRow const):
(WebCore::AccessibilityNodeObject::axColumnSpan const):
(WebCore::AccessibilityNodeObject::axRowSpan const):
(WebCore::AccessibilityNodeObject::ensureIndexesUpToDate const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::readOnlyValue const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::titleUIElement const):
(WebCore::AccessibilityRenderObject::computeIsIgnored const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addChildren):
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/AccessibilityTableCell.cpp: Removed.
* Source/WebCore/accessibility/AccessibilityTableCell.h: Removed.
* Source/WebCore/accessibility/AccessibilityTree.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableCellParent]):
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):
(-[WebAccessibilityObjectWrapper accessibilityRowIndexDescription]):
(-[WebAccessibilityObjectWrapper accessibilityColumnIndexDescription]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::parentTableIfTableCell const):
(WebCore::AXIsolatedObject::parentTable const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::objectChangedIgnoredState):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
Canonical link: https://commits.webkit.org/299635@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
