Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 898eb53bceb3c431c7516e2e4bc09b3e55ed7e99
https://github.com/WebKit/WebKit/commit/898eb53bceb3c431c7516e2e4bc09b3e55ed7e99
Author: Jessica Lee <[email protected]>
Date: 2025-09-05 (Fri, 05 Sep 2025)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
M Tools/TestWebKitAPI/cocoa/TestDownloadDelegate.h
M Tools/TestWebKitAPI/cocoa/TestDownloadDelegate.mm
Log Message:
-----------
(New-Test) [ iOS Debug ] TestWebKitAPI.WKDownload.PlaceholderPolicyDisable is
a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=298464
rdar://156426293
Reviewed by Per Arne Vollan.
This test was timing out because the attached observer is never notified of any
progress on the file downloads.
It needs to track the progress from the WKDownload object rather than the file
itself.
But we are changing the test to better validate the placeholder policy during
downloads. Rather than check the progress
of the downloads, instead we will check that the destination file correctly
downloads and confirm that the
provided placeholder file is deleted after a successful download.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::PlaceholderPolicyEnable)):
(TestWebKitAPI::PlaceholderPolicyDisable)):
(-[ProgressObserver init]): Deleted.
(-[ProgressObserver observeValueForKeyPath:ofObject:change:context:]): Deleted.
(-[ProgressObserver waitForProgress]): Deleted.
* Tools/TestWebKitAPI/cocoa/TestDownloadDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestDownloadDelegate.mm:
(-[TestDownloadDelegate _download:decidePlaceholderPolicy:]):
Canonical link: https://commits.webkit.org/299651@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
