Title: [113260] trunk/Source/WebCore
Revision
113260
Author
[email protected]
Date
2012-04-04 16:23:28 -0700 (Wed, 04 Apr 2012)

Log Message

Paginated webviews render nothing in their gutters
https://bugs.webkit.org/show_bug.cgi?id=83231

Reviewed by Adele Peterson.

When the RenderView has columns, nothing draws in the gutters.

* page/FrameView.cpp:
(WebCore::FrameView::paintContents): Paint the background color behind everything when
paginated.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (113259 => 113260)


--- trunk/Source/WebCore/ChangeLog	2012-04-04 23:17:35 UTC (rev 113259)
+++ trunk/Source/WebCore/ChangeLog	2012-04-04 23:23:28 UTC (rev 113260)
@@ -1,3 +1,16 @@
+2012-04-04  Dan Bernstein  <[email protected]>
+
+        Paginated webviews render nothing in their gutters
+        https://bugs.webkit.org/show_bug.cgi?id=83231
+
+        Reviewed by Adele Peterson.
+
+        When the RenderView has columns, nothing draws in the gutters.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::paintContents): Paint the background color behind everything when
+        paginated.
+
 2012-04-04  Mark Pilgrim  <[email protected]>
 
         Call histogramEnumeration directly

Modified: trunk/Source/WebCore/page/FrameView.cpp (113259 => 113260)


--- trunk/Source/WebCore/page/FrameView.cpp	2012-04-04 23:17:35 UTC (rev 113259)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-04-04 23:23:28 UTC (rev 113260)
@@ -2973,6 +2973,10 @@
         p->fillRect(rect, Color(0xFF, 0, 0), ColorSpaceDeviceRGB);
 #endif
 
+    Page* page = m_frame->page();
+    if (page->mainFrame() == m_frame && page->pagination().mode != Page::Pagination::Unpaginated)
+        p->fillRect(rect, baseBackgroundColor(), ColorSpaceDeviceRGB);
+
     bool isTopLevelPainter = !sCurrentPaintTimeStamp;
     if (isTopLevelPainter)
         sCurrentPaintTimeStamp = currentTime();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to