Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d1de07e2a0b99fc6b8324fdadd0a957bee7ab78
      
https://github.com/WebKit/WebKit/commit/4d1de07e2a0b99fc6b8324fdadd0a957bee7ab78
  Author: Abrar Rahman Protyasha <a_protya...@apple.com>
  Date:   2025-08-22 (Fri, 22 Aug 2025)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm

  Log Message:
  -----------
  [macOS] Several API tests interacting with the PDF HUD are failing
https://bugs.webkit.org/show_bug.cgi?id=296970
rdar://157605203

Reviewed by Wenson Hsieh.

The PDF HUD was not being displayed because we were failing occlusion
checks, expectedly so given TestWebKitAPI. To workaround this, we follow
suit from PlatformWKWebView and  -_setWindowOcclusionDetectionEnabled:NO
on the relevant web views.

As a drive-by, I also wrapped all the HUD tests behind an ENABLE_PDF_HUD
conditional, assuming we will get this test coverage for free if we ever
bring ENABLE_PDF_HUD to other platforms.

Canonical link: https://commits.webkit.org/299080@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to