Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d47b3493ba2d509f1304ff5868b5b244a717f240
https://github.com/WebKit/WebKit/commit/d47b3493ba2d509f1304ff5868b5b244a717f240
Author: Charlie Wolfe <charl...@apple.com>
Date: 2025-08-19 (Tue, 19 Aug 2025)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
Log Message:
-----------
REGRESSSION(294690@main): Crash in `WebPageProxy::beginSafeBrowsingCheck`
https://bugs.webkit.org/show_bug.cgi?id=297577
rdar://156557789
Reviewed by Alex Christensen.
This patch fixes several issues in this function:
- showBrowsingWarning was being called on WebPageProxy without a null check.
- url is not using isolatedCopy() across threads.
- weakThis was never being used.
- RefPtr<API::Navigation> was used in the function parameters.
- WebFrameProxy was only being passed to call isMainFrame(), we should just
pass a bool variable instead.
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* Source/WebKit/UIProcess/WebPageProxy.h:
Canonical link: https://commits.webkit.org/298897@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
