Title: [113173] trunk/Source/WebKit/efl
- Revision
- 113173
- Author
- commit-qu...@webkit.org
- Date
- 2012-04-04 05:24:31 -0700 (Wed, 04 Apr 2012)
Log Message
[EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.
https://bugs.webkit.org/show_bug.cgi?id=82438
Patch by Grzegorz Czajkowski <g.czajkow...@samsung.com> on 2012-04-04
Reviewed by Andreas Kling.
The purpose of ewk_settings_icon_database_icon_object_add is to get icon
for the given URL. This function doesn't add anything to database.
Documentation and API name are adjusted.
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_object_get):
* ewk/ewk_settings.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (113172 => 113173)
--- trunk/Source/WebKit/efl/ChangeLog 2012-04-04 12:21:14 UTC (rev 113172)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-04-04 12:24:31 UTC (rev 113173)
@@ -1,3 +1,18 @@
+2012-04-04 Grzegorz Czajkowski <g.czajkow...@samsung.com>
+
+ [EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.
+ https://bugs.webkit.org/show_bug.cgi?id=82438
+
+ Reviewed by Andreas Kling.
+
+ The purpose of ewk_settings_icon_database_icon_object_add is to get icon
+ for the given URL. This function doesn't add anything to database.
+ Documentation and API name are adjusted.
+
+ * ewk/ewk_settings.cpp:
+ (ewk_settings_icon_database_icon_object_get):
+ * ewk/ewk_settings.h:
+
2012-04-03 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
[EFL] DRT support for setInteractiveFormValidationEnabled
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.cpp (113172 => 113173)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2012-04-04 12:21:14 UTC (rev 113172)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2012-04-04 12:24:31 UTC (rev 113173)
@@ -228,7 +228,7 @@
return icon->nativeImageForCurrentFrame();
}
-Evas_Object* ewk_settings_icon_database_icon_object_add(const char* url, Evas* canvas)
+Evas_Object* ewk_settings_icon_database_icon_object_get(const char* url, Evas* canvas)
{
EINA_SAFETY_ON_NULL_RETURN_VAL(url, 0);
EINA_SAFETY_ON_NULL_RETURN_VAL(canvas, 0);
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (113172 => 113173)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.h 2012-04-04 12:21:14 UTC (rev 113172)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.h 2012-04-04 12:24:31 UTC (rev 113173)
@@ -175,7 +175,7 @@
EAPI cairo_surface_t *ewk_settings_icon_database_icon_surface_get(const char *url);
/**
- * Creates Evas_Object of type image representing the given URL.
+ * Gets image representing the given URL.
*
* This is an utility function that creates an Evas_Object of type
* image set to have fill always match object size
@@ -184,13 +184,16 @@
* @note In order to have this working, one must open icon database
* with ewk_settings_icon_database_path_set().
*
+ * @note The "load,finished" signal doesn't guarantee that icons are completely loaded and
+ * saved to database. Icon can be taken after the "icon,received" signal.
+ *
* @param url which url to query icon
* @param canvas evas instance where to add resulting object
*
* @return newly allocated Evas_Object instance or @c 0 on
* errors. Delete the object with evas_object_del().
*/
-EAPI Evas_Object *ewk_settings_icon_database_icon_object_add(const char *url, Evas *canvas);
+EAPI Evas_Object *ewk_settings_icon_database_icon_object_get(const char *url, Evas *canvas);
/**
* Sets the path where the application cache will be stored.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes