Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96f38d2c773be8232e6512f628d6e543c0671634 https://github.com/WebKit/WebKit/commit/96f38d2c773be8232e6512f628d6e543c0671634 Author: Alan Baradlay <za...@apple.com> Date: 2025-08-17 (Sun, 17 Aug 2025)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-003-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollWidthHeight-negative-margin-002-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderFlexibleBox.cpp M Source/WebCore/rendering/RenderFlexibleBox.h Log Message: ----------- Padding end should contribute to scrollable overflow when inline direction is flipped https://bugs.webkit.org/show_bug.cgi?id=297466 Reviewed by Antti Koivisto. When content is inline-flipped, the padding end (in case of simple horizontal flow, it is visually right padding), contributes to scrollable overflow where it may produce a scrollable rect that starts outside of the container. e.g. <div style="direction: rtl; width: 1200px; padding-left: 1000px"> <div style="width: 400px"> 1200px -200px _______________________ ______|___________ ________ | | | || || | 1000px || 400px || |______|___________||________|| |______________________| The 400px wide child box (aligned at the right edge of the container) is positioned at 800px. Now the padding (end) needs 1000px space which "pushes" the scrollable overflow all the way to -200px. * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-003-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollWidthHeight-negative-margin-002-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowWithRendererOffset): * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): (WebCore::RenderFlexibleBox::isWrapReverse const): (WebCore::RenderFlexibleBox::crossAxisDirection const): (WebCore::RenderFlexibleBox::performFlexLayout): (WebCore::RenderFlexibleBox::staticCrossAxisPositionForPositionedFlexItem): (WebCore::RenderFlexibleBox::alignmentForFlexItem const): (WebCore::RenderFlexibleBox::alignFlexLines): (WebCore::RenderFlexibleBox::alignFlexItems): (WebCore::RenderFlexibleBox::performBaselineAlignment): (WebCore::RenderFlexibleBox::flexItemForFirstBaseline const): (WebCore::RenderFlexibleBox::flexItemForLastBaseline const): * Source/WebCore/rendering/RenderFlexibleBox.h: Canonical link: https://commits.webkit.org/298818@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes