Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 38118fcbd4f510983f40219a74caf5257139aaec
https://github.com/WebKit/WebKit/commit/38118fcbd4f510983f40219a74caf5257139aaec
Author: Matthew Finkel <m_fin...@apple.com>
Date: 2025-08-15 (Fri, 15 Aug 2025)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/http/tests/clear-site-data/set-and-clear-cookies.https.html
M
LayoutTests/http/tests/cookies/accept-partitioned-first-and-third-party-cookies.https.html
A LayoutTests/http/tests/cookies/max-partitioned-cookies.https-expected.txt
A LayoutTests/http/tests/cookies/max-partitioned-cookies.https.html
M LayoutTests/http/tests/cookies/multiple-cookies-expected.txt
A LayoutTests/http/tests/cookies/multiple-cookies-iframes.https-expected.txt
A LayoutTests/http/tests/cookies/multiple-cookies-iframes.https.html
M
LayoutTests/http/tests/cookies/multiple-cookies-with-partitioned.https.html
M LayoutTests/http/tests/cookies/multiple-cookies.html
A LayoutTests/http/tests/cookies/multiple-cookies.https-expected.txt
A LayoutTests/http/tests/cookies/multiple-cookies.https.html
M
LayoutTests/http/tests/cookies/only-accept-first-party-cookies-expected.txt
M LayoutTests/http/tests/cookies/only-accept-first-party-cookies.html
M LayoutTests/http/tests/cookies/resources/echo-cookies.py
M LayoutTests/http/tests/cookies/resources/set-cookie-and-redirect-back.py
M LayoutTests/http/tests/cookies/resources/set-cookie-and-serve.py
A
LayoutTests/http/tests/resourceLoadStatistics/only-accept-first-party-cookies-with-third-party-cookie-blocking-expected.txt
A
LayoutTests/http/tests/resourceLoadStatistics/only-accept-first-party-cookies-with-third-party-cookie-blocking.html
A
LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect-fetch.https-expected.txt
A
LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect-fetch.https.html
M LayoutTests/http/tests/resources/redirect.py
A
LayoutTests/http/tests/storageAccess/deny-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https-expected.txt
A
LayoutTests/http/tests/storageAccess/deny-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html
M
LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Tools/TestWebKitAPI/Info.plist
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
Log Message:
-----------
Add some more regression tests for cookies
https://bugs.webkit.org/show_bug.cgi?id=297084
rdar://problem/157788048
Reviewed by Charlie Wolfe.
Add some more tests that cover cookie behavior. The tests are focused on
partitioned cookies, but it covers some other cookie behavior as a side-effect
because I want to make sure that unpartitioned cookies interact with
partitioned in the expected way.
There are some failing tests for two reasons. The first reason is related to
how the implementation handles first-party partitioned cookies. This may
require changes.
The second reason is because in one of the tests I am testing how cookies
behave within the first-party and third-party contexts, and the test doesn't
correctly decide pass/fail in some cases. I will update the test so the test
expectations show that the tests pass as expected in a follow up PR.
The single API test is a new regression for the cookieTransformCallback
behavior. I needed to allow insecure connections in TestWebKitAPI for this.
* LayoutTests/TestExpectations:
* LayoutTests/http/tests/clear-site-data/set-and-clear-cookies.https.html:
*
LayoutTests/http/tests/cookies/accept-partitioned-first-and-third-party-cookies.https.html:
* LayoutTests/http/tests/cookies/max-partitioned-cookies.https-expected.txt:
Added.
* LayoutTests/http/tests/cookies/max-partitioned-cookies.https.html: Added.
* LayoutTests/http/tests/cookies/multiple-cookies-expected.txt:
* LayoutTests/http/tests/cookies/multiple-cookies-iframes.https-expected.txt:
Added.
* LayoutTests/http/tests/cookies/multiple-cookies-iframes.https.html: Added.
* LayoutTests/http/tests/cookies/multiple-cookies-with-partitioned.https.html:
* LayoutTests/http/tests/cookies/multiple-cookies.html:
* LayoutTests/http/tests/cookies/multiple-cookies.https-expected.txt: Added.
* LayoutTests/http/tests/cookies/multiple-cookies.https.html: Added.
* LayoutTests/http/tests/cookies/only-accept-first-party-cookies-expected.txt:
* LayoutTests/http/tests/cookies/only-accept-first-party-cookies.html:
* LayoutTests/http/tests/cookies/resources/echo-cookies.py:
* LayoutTests/http/tests/cookies/resources/set-cookie-and-redirect-back.py:
* LayoutTests/http/tests/cookies/resources/set-cookie-and-serve.py:
*
LayoutTests/http/tests/resourceLoadStatistics/only-accept-first-party-cookies-with-third-party-cookie-blocking-expected.txt:
Copied from
LayoutTests/http/tests/cookies/only-accept-first-party-cookies-expected.txt.
*
LayoutTests/http/tests/resourceLoadStatistics/only-accept-first-party-cookies-with-third-party-cookie-blocking.html:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect-fetch.https-expected.txt:
Added.
*
LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect-fetch.https.html:
Added.
* LayoutTests/http/tests/resources/redirect.py:
(set_cookie):
(add_cors):
*
LayoutTests/http/tests/storageAccess/deny-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https-expected.txt:
Added.
*
LayoutTests/http/tests/storageAccess/deny-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html:
Copied from
LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html.
Similar to the other "deny" test, this won't work until we add support for
rejecting the prompt.
*
LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-with-partitioned-cookies.https.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* Tools/TestWebKitAPI/Info.plist:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(-[SessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(TEST(Navigation, CookieTransformOnRedirect)):
Canonical link: https://commits.webkit.org/298786@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
