Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 703a3c5807b37e2f6a79400150b5b47d486e0c89
https://github.com/WebKit/WebKit/commit/703a3c5807b37e2f6a79400150b5b47d486e0c89
Author: Ahmad Saleem <ahmad.saleem792+git...@gmail.com>
Date: 2025-08-15 (Fri, 15 Aug 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-002-dynamic-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-003-dynamic-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-005-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-group-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowcol-001-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowcol-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-002-border-separate-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-002-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-003-border-separate-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-003-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-004-dynamic-expected.txt
M
LayoutTests/platform/glib/tables/mozilla_expected_failures/other/test4-expected.txt
M
LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
M Source/WebCore/rendering/RenderTableSection.cpp
Log Message:
-----------
Fix collapsed table row height without affecting row distribution
https://bugs.webkit.org/show_bug.cgi?id=297380
rdar://158276634
Reviewed by Alan Baradlay.
Previously, collapsed rows could retain nonzero height or shift subsequent rows,
causing failures in rowspan and collapsed-row cases.
This patch adds post-processe computed row heights: for each collapsed row, any
height is removed by shifting subsequent row positions up, making the collapsed
row height zero without altering other rows' heights.
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
> Progressions:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-002-dynamic-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-003-dynamic-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-005-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-row-group-002-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowcol-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowcol-002-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-002-border-separate-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-002-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-003-border-separate-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-003-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-tables/visibility-collapse-rowspan-004-dynamic-expected.txt:
* LayoutTests/TestExpectations: Unskip two tests
> Rebaselines:
*
LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
*
LayoutTests/platform/glib/tables/mozilla_expected_failures/other/test4-expected.txt:
*
LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt:
Canonical link: https://commits.webkit.org/298783@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
