Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f7cd5bc469411f0807f10d7212fb997c7f9052ca
https://github.com/WebKit/WebKit/commit/f7cd5bc469411f0807f10d7212fb997c7f9052ca
Author: Matthew Finkel <[email protected]>
Date: 2025-08-14 (Thu, 14 Aug 2025)
Changed paths:
M Source/WebCore/platform/network/NetworkStorageSession.cpp
M Source/WebCore/platform/network/NetworkStorageSession.h
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm
Log Message:
-----------
[chips] Block all third-party cookies when CHIPS is disabled
https://bugs.webkit.org/show_bug.cgi?id=296892
rdar://157495921
Reviewed by Sihui Liu.
Currently, we don't fully enforce third-party cookie blocking when the CHIPS
compile-time flag is true but the run-time flag is false. The expected behavior
is that we would fallback to using the shipping ITP behavior, where we block
all third-party cookies, without regard for partitioned cookies.
This patch adjusts the logic so that we block all third party cookies unless
third-party cookie blocking is disabled. It also simplifies the code by
combining duplicate code into NetworkStorageSession::shouldBlockCookies.
This is covered by a currently skipped tests, and some tests that will be
included in a future PR. We can't currently test this behavior because CHIPS is
disabled at compile-time.
* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::thirdPartyCookieBlockingDecisionForRequest
const):
(WebCore::NetworkStorageSession::shouldBlockCookies const):
(WebCore::NetworkStorageSession::shouldBlockCookies):
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::requestThirdPartyCookieBlockingDecision const):
(WebKit::NetworkTaskCocoa::willPerformHTTPRedirection):
(WebKit::NetworkTaskCocoa::shouldBlockCookies): Deleted.
Canonical link: https://commits.webkit.org/298695@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
