Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ecc04282f35569923cd1629efadeaae7d84ee94
      
https://github.com/WebKit/WebKit/commit/3ecc04282f35569923cd1629efadeaae7d84ee94
  Author: Nipun Shukla <[email protected]>
  Date:   2025-08-12 (Tue, 12 Aug 2025)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Update state if WKNavigationDelegate responds with 
WKNavigationActionPolicyCancel when RemoteFrames are being navigated
https://bugs.webkit.org/show_bug.cgi?id=296461
rdar://116203453

Reviewed by Alex Christensen.

After an investigation it was discovered that WKNavigationActionPolicyCancel 
and WKNavigationResponsePolicyCancel both call didFailProvisionalNavigation() 
or one of its variants, effectively cleaning up any cross process state 
pollution, even with site isolation enabled. This confirms cleanup by adding an 
assert on the existence of a provisional frame in createProvisionalFrame() and 
having a test which would trigger the assert as a fail condition.

* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createProvisionalFrame):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, 
CancelNavigationResponseCleansUpProvisionalFrame)):
(TestWebKitAPI::TEST(SiteIsolation, 
CancelNavigationActionCleansUpProvisionalFrame)):

Canonical link: https://commits.webkit.org/298599@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to