Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68ee5059655db26efab6e4c26b69f08d2d0bec3e
      
https://github.com/WebKit/WebKit/commit/68ee5059655db26efab6e4c26b69f08d2d0bec3e
  Author: Diego Pino Garcia <[email protected]>
  Date:   2025-08-12 (Tue, 12 Aug 2025)

  Changed paths:
    R 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-with-input-expected.txt
    M Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
    M Tools/MiniBrowser/wpe/main.cpp

  Log Message:
  -----------
  [WPE] <dialog> does not close if Escape is pressed inside a contenteditable 
element
https://bugs.webkit.org/show_bug.cgi?id=297091

Reviewed by Carlos Garcia Campos.

This commit fixes two issues related to handling of 'Escape' character
in WPEWebKit.

First one, when WPE's MiniBrowser handles the 'Escape' character it
should return FALSE, so the keypress also reaches the UIProcess.

Then, 'WebEditorClientWPE' should not capture 'Escape' to emit a 'Cancel'
command. In addition, 'Cancel' is not a command in 'EditorCommand.cpp'.

* 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-cancel-with-input-expected.txt:
 Removed.
* Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:
* Tools/MiniBrowser/wpe/main.cpp:

Canonical link: https://commits.webkit.org/298562@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to