Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 51961a5a88419fefa2fb98de35fbd979e2c72bcc
https://github.com/WebKit/WebKit/commit/51961a5a88419fefa2fb98de35fbd979e2c72bcc
Author: Kimmo Kinnunen <[email protected]>
Date: 2025-08-08 (Fri, 08 Aug 2025)
Changed paths:
M Source/ThirdParty/ANGLE/src/common/PoolAlloc.cpp
M Source/ThirdParty/ANGLE/src/common/PoolAlloc.h
M Source/ThirdParty/ANGLE/src/common/PoolAlloc_unittest.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h
Log Message:
-----------
ANGLE: Simplify PoolAllocator further
https://bugs.webkit.org/show_bug.cgi?id=297041
rdar://157725945
Reviewed by Dan Glastonbury.
- Remove distinct implementations of the member functions when
ANGLE_DISABLE_POOL_ALLOC is defined
- Support guards with ANGLE_DISABLE_POOL_ALLOC.
- Hardcode alignment
- Store the segments in a std::vector instead linked list entries inside
the pools
- Avoid having padding guard and after guard, just have padding guard
if needed, otherwise after guard
- Increase pool size from 16k to 32k
* Source/ThirdParty/ANGLE/src/common/PoolAlloc.cpp:
(angle::PoolAllocator::Segment::Segment):
(angle::PoolAllocator::Segment::~Segment):
(angle::PoolAllocator::Segment::operator=):
(angle::PoolAllocator::Segment::Allocate):
(angle::PoolAllocator::Segment::data const):
(angle::PoolAllocator::~PoolAllocator):
(angle::PoolAllocator::addGuard):
(angle::PoolAllocator::reset):
(angle::PoolAllocator::allocateNewPoolSegment):
(angle::PoolAllocator::allocateSingleObject):
(angle::PoolAllocator::PoolAllocator): Deleted.
(angle::PoolAllocator::PageHeader::PageHeader): Deleted.
(angle::PoolAllocator::adjustAllocationExtent const): Deleted.
(angle::PoolAllocator::allocateNewPage): Deleted.
(angle::PoolAllocator::allocate): Deleted.
* Source/ThirdParty/ANGLE/src/common/PoolAlloc.h:
(angle::PoolAllocator::allocate):
(angle::PoolAllocator::adjustAllocationExtent const): Deleted.
(angle::PoolAllocator::addGuard): Deleted.
(angle::PoolAllocator::bump): Deleted.
* Source/ThirdParty/ANGLE/src/common/PoolAlloc_unittest.cpp:
(angle::TEST_F(PoolAllocatorTest, Interface)):
(angle::TEST_F(PoolAllocatorTest, Alignment)):
(angle::TEST_F(PoolAllocatorTest, ResetRecyclesMemory)):
(angle::TEST_F(PoolAllocatorGuardTest, AlignmentGuardDetectsOverflowWrite)):
(angle::TEST_F(PoolAllocatorGuardTest, AllocationGuardsDetectsOverflowWrite)):
(angle::TEST_F(PoolAllocatorGuardTest, AllocationGuardsDetectsUnderflowWrite)):
(angle::PoolAllocatorTest::GetAlignment): Deleted.
(angle::TEST_P): Deleted.
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h:
Canonical link: https://commits.webkit.org/298409@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
