Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e9f4b0b606174d25d5d52b60c8ce177974dae214
https://github.com/WebKit/WebKit/commit/e9f4b0b606174d25d5d52b60c8ce177974dae214
Author: Megan Gardner <[email protected]>
Date: 2025-08-07 (Thu, 07 Aug 2025)
Changed paths:
M Source/WebCore/dom/Element.cpp
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/editing/FrameSelection.h
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/Page.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
Log Message:
-----------
Condense option flags for revealSelection.
https://bugs.webkit.org/show_bug.cgi?id=297065
rdar://157768808
Reviewed by Abrar Rahman Protyasha and Aditya Keerthi.
The options being passed individually to revealSelection
have gotten out of hand. I believe I will need to add more
to it soon, so I'm condensing them down to a struct before I
have to start adding more flags.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::revealSelectionAfterEditingOperation):
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):
* Source/WebCore/editing/FrameSelection.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::revealCurrentSelection):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::centerSelectionInVisibleArea):
* Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::didFindString):
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(-[WebFrame revealSelectionAtExtent:]):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):
Canonical link: https://commits.webkit.org/298361@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
