Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ba57ebdfc9fd45a248b6c73d4ae41d534ee60eb
https://github.com/WebKit/WebKit/commit/5ba57ebdfc9fd45a248b6c73d4ae41d534ee60eb
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-08-01 (Fri, 01 Aug 2025)
Changed paths:
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/LegacyPDFPluginTests.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFTestHelpers.h
A Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFTestHelpers.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm
R Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.h
R Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
M Tools/TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm
Log Message:
-----------
Follow up to 298023@main: Restore test coverage for legacy PDF plugin
https://bugs.webkit.org/show_bug.cgi?id=296763
rdar://157238826
Reviewed by Aditya Keerthi.
After 298023@main, we no longer have API tests running for the legacy
PDF plugin implementation. These tests are valid and should work across
implementations, so let's restore them -- see LegacyPDFPluginTests.mm.
This patch also takes the opportunity to remove the Unified prefix from
UnifiedPDFTestHelpers since said helpers are no longer specific to
UnifiedPDF. We move more utilities in this unit and start using them in
the legacy PDF test suite.
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LegacyPDFPluginTests.mm: Added.
(TestWebKitAPI::TEST(LegacyPDF, PrintSize)):
(TestWebKitAPI::TEST(LegacyPDF, SetPageZoomFactorDoesNotBailIncorrectly)):
(TestWebKitAPI::checkFrame):
(TestWebKitAPI::TEST(LegacyPDF, PDFHUDMainResourcePDF)):
(TestWebKitAPI::TEST(LegacyPDF, PDFHUDNestedIFrames)):
(TestWebKitAPI::TEST(LegacyPDF, PDFHUDIFrame3DTransform)):
(TestWebKitAPI::TEST(LegacyPDF, PDFHUDMultipleIFrames)):
(TestWebKitAPI::TEST(LegacyPDF, PDFHUDLoadPDFTypeWithPluginsBlocked)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFTestHelpers.h: Renamed from
Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.h.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFTestHelpers.mm: Renamed from
Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTestHelpers.mm.
(-[PDFPrintUIDelegate _webView:printFrame:pdfFirstPageSize:completionHandler:]):
(-[PDFPrintUIDelegate waitForPageSize]):
(-[PDFPrintUIDelegate lastPrintedFrame]):
(TestWebKitAPI::testPDFData):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(-[PDFPrintUIDelegate
_webView:printFrame:pdfFirstPageSize:completionHandler:]): Deleted.
(-[PDFPrintUIDelegate waitForPageSize]): Deleted.
(-[PDFPrintUIDelegate lastPrintedFrame]): Deleted.
(TestWebKitAPI::testPDFData): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
* Tools/TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm:
Canonical link: https://commits.webkit.org/298118@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
