Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85b245b8d68633ad701d721174c47f9183ae5725
https://github.com/WebKit/WebKit/commit/85b245b8d68633ad701d721174c47f9183ae5725
Author: Dana Estra <[email protected]>
Date: 2025-07-31 (Thu, 31 Jul 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size_while_paused-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size_while_paused-ref.html
Log Message:
-----------
WebVTT rendering tests' reference cue x-positions do not match actual vtt
https://bugs.webkit.org/show_bug.cgi?id=296665
rdar://136809019
Reviewed by Eric Carlson.
In dom_override_cue_align_position_line_size and
dom_override_cue_align_position_line_size_while_paused,
the vtt is given a position of 80%. However, in the corresponding ref files,
the cue is given css style
"right: 51.2px." But the video has a width of 320px, so the ref cue should have
"right:64px" (20%)
or "left:256px" (80%). This patch replaces "right: 51.2px" with "left: 80%".
This patch also replaces
"width:64px" with "width:20%" so that the value is not hardcoded.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size-ref.html:
*
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size_while_paused-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/cues-with-video/processing-model/dom_override_cue_align_position_line_size_while_paused-ref.html:
Canonical link: https://commits.webkit.org/298087@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
