Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 676ffb9985a4ac19525b059ba87ece65c6c41dad
      
https://github.com/WebKit/WebKit/commit/676ffb9985a4ac19525b059ba87ece65c6c41dad
  Author: Brianna Fan <[email protected]>
  Date:   2025-07-30 (Wed, 30 Jul 2025)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_exporter.py

  Log Message:
  -----------
  export-w3c-test-changes creates duplicate branches instead of updating 
pre-existing export branch
https://bugs.webkit.org/show_bug.cgi?id=296656
rdar://156960581

Reviewed by Tim Nguyen.

Before 296936@main, the branch name got a suffix if `git show-ref --verify 
--quiet {branch_name}` == 0.
However, the branch name would never match with the ref since it didn't have 
the "refs/heads" prefix.
296936@main fixed this by using `branches_for`, but the duplicate branching is 
actually not what we want.

Having an existing branch get updated with new changes is the desired 
behaviour, so this PR removes the
logic in `_ensure_new_branch_name` and simply creates a branch name with the 
`wpt-export-for-webkit-` prefix.

* Tools/Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._branch_name):
(WebPlatformTestExporter._ensure_wpt_repository):
(WebPlatformTestExporter.create_wpt_pull_request):
(WebPlatformTestExporter._ensure_new_branch_name): Deleted.

Canonical link: https://commits.webkit.org/298053@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to