Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 81e80d31ecc25c186b8679d1ab93114cce97f809
https://github.com/WebKit/WebKit/commit/81e80d31ecc25c186b8679d1ab93114cce97f809
Author: Basuke Suzuki <[email protected]>
Date: 2025-07-22 (Tue, 22 Jul 2025)
Changed paths:
M LayoutTests/platform/wk2/TestExpectations
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp
M Source/WebCore/page/Navigation.cpp
Log Message:
-----------
[Navigation API] NavigateEvent.intercept() doesn't handle exception correctly
in its handler().
https://bugs.webkit.org/show_bug.cgi?id=296104
rdar://156007630
Reviewed by Chris Dumez.
If exception happens, it will be caught by unhandled rejection handler.
Change CodeGeneratorJS.pm to use rejectAsHandled() instead of reject()
when callback functions throw exceptions. This prevents spurious
"unhandled promise rejection" console warnings for framework-managed
promise rejections in Navigation API, Web Locks API, and View
Transitions API.
* LayoutTests/platform/wk2/TestExpectations:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementationOperationBody):
* Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
(WebCore::JSTestCallbackInterface::callbackThatTreatsExceptionAsRejectedPromise):
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::innerDispatchNavigateEvent):
Canonical link: https://commits.webkit.org/297745@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
