Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 26906da8b16296f99cbe56166aa5cfd6c2771053
https://github.com/WebKit/WebKit/commit/26906da8b16296f99cbe56166aa5cfd6c2771053
Author: Andy Estes <[email protected]>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift
M Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h
Log Message:
-----------
[visionOS] Include a log identifier in LinearMediaPlayer logging
https://bugs.webkit.org/show_bug.cgi?id=293524
rdar://151957283
Reviewed by Jer Noble.
Prefixed LinearMediaPlayer's log messages with PlaybackSessionInterface's log
identifier so that we
can correlate them with other media logging.
Ideally this would have been done with a Swift macro, but this isn't currently
practical with
Apple's build system. To avoid letting the perfect be the enemy of the good,
this just modifies
each logging call site to include the log identifier. While here, use a
CheckedPtr when
dereferencing WKLinearMediaPlayerDelegate._model.
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(-[WKLinearMediaPlayerDelegate linearMediaPlayerPlay:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerPause:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerTogglePlayback:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setPlaybackRate:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:seekByDelta:]):
(-[WKLinearMediaPlayerDelegate
linearMediaPlayer:seekToDestination:fromSource:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:seekThumbnailToTime:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerBeginScrubbing:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerEndScrubbing:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerBeginScanningForward:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerEndScanningForward:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerBeginScanningBackward:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerEndScanningBackward:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setVolume:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setMuted:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setAudioTrack:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setLegibleTrack:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerEnterFullscreen:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerExitFullscreen:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setVideoReceiverEndpoint:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerClearVideoReceiverEndpoint:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerLogIdentifier:]):
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift:
(WKSLinearMediaPlayer.isImmersiveVideo):
(WKSLinearMediaPlayer.logIdentifier):
(WKSLinearMediaPlayer.makeViewController):
(WKSLinearMediaPlayer.enterExternalPresentation(_:(any Error)?) -> Void:)):
(WKSLinearMediaPlayer.exitExternalPresentation(_:(any Error)?) -> Void:)):
(WKSLinearMediaPlayer.enterFullscreen(_:(any Error)?) -> Void:)):
(WKSLinearMediaPlayer.exitFullscreen(_:(any Error)?) -> Void:)):
(WKSLinearMediaPlayer.presentationStateChanged(_:)):
(WKSLinearMediaPlayer.play):
(WKSLinearMediaPlayer.pause):
(WKSLinearMediaPlayer.togglePlayback):
(WKSLinearMediaPlayer.setPlaybackRate(_:)):
(WKSLinearMediaPlayer.seek(to:)):
(WKSLinearMediaPlayer.seek(_:)):
(WKSLinearMediaPlayer.seek(to:from:metadata:)):
(WKSLinearMediaPlayer.completeTrimming(_:)):
(WKSLinearMediaPlayer.updateStartTime(_:)):
(WKSLinearMediaPlayer.updateEndTime(_:)):
(WKSLinearMediaPlayer.beginEditingVolume):
(WKSLinearMediaPlayer.endEditingVolume):
(WKSLinearMediaPlayer.setAudioTrack(_:)):
(WKSLinearMediaPlayer.setLegibleTrack(_:)):
(WKSLinearMediaPlayer.skipActiveInterstitial):
(WKSLinearMediaPlayer.setCaptionContentInsets(_:)):
(WKSLinearMediaPlayer.updateVideoBounds(_:)):
(WKSLinearMediaPlayer.updateViewingMode(_:)):
(WKSLinearMediaPlayer.togglePip):
(WKSLinearMediaPlayer.toggleInlineMode):
(WKSLinearMediaPlayer.willEnterFullscreen):
(WKSLinearMediaPlayer.didCompleteEnterFullscreen(_:any:)):
(WKSLinearMediaPlayer.willExitFullscreen):
(WKSLinearMediaPlayer.didCompleteExitFullscreen(_:any:)):
(WKSLinearMediaPlayer.makeDefaultEntity):
(WKSLinearMediaPlayer.setTimeResolverInterval(_:)):
(WKSLinearMediaPlayer.setTimeResolverResolution(_:)):
(WKSLinearMediaPlayer.setThumbnailSize(_:)):
(WKSLinearMediaPlayer.seekThumbnail(to:)):
(WKSLinearMediaPlayer.beginScrubbing):
(WKSLinearMediaPlayer.endScrubbing):
(WKSLinearMediaPlayer.beginScanningForward):
(WKSLinearMediaPlayer.endScanningForward):
(WKSLinearMediaPlayer.beginScanningBackward):
(WKSLinearMediaPlayer.endScanningBackward):
(WKSLinearMediaPlayer.setVolume(_:)):
(WKSLinearMediaPlayer.setIsMuted(_:)):
(WKSLinearMediaPlayer.setVideoReceiverEndpoint(_:)):
* Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h:
Canonical link: https://commits.webkit.org/297703@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
