Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b4f51ab4b856a0be1cabda03bc2c49285d507fd
https://github.com/WebKit/WebKit/commit/5b4f51ab4b856a0be1cabda03bc2c49285d507fd
Author: Alan Baradlay <za...@apple.com>
Date: 2025-07-17 (Thu, 17 Jul 2025)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/rendering/RenderAttachment.cpp
M Source/WebCore/rendering/RenderAttachment.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderButton.cpp
M Source/WebCore/rendering/RenderButton.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListBox.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderMenuList.h
M Source/WebCore/rendering/RenderSlider.cpp
M Source/WebCore/rendering/RenderSlider.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTextControl.h
M Source/WebCore/rendering/RenderTextControlMultiLine.cpp
M Source/WebCore/rendering/RenderTextControlMultiLine.h
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.h
Log Message:
-----------
[Cleanup] Move RenderBox::baselinePosition and overrides to IFC integration
layer
https://bugs.webkit.org/show_bug.cgi?id=295161
Reviewed by Antti Koivisto.
IFC (correctly) is the only client of baselinePosition() at this point.
Moving all this code over to IFC helps to unify the baseline computation (which
seems rather random atm).
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::baselinePosition):
(WebCore::LayoutIntegration::setIntegrationBaseline):
* Source/WebCore/rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderAttachment.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::synthesizedBaselineFromContentBox): Deleted.
(WebCore::RenderButton::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderButton.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderSlider.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition const): Deleted.
* Source/WebCore/rendering/RenderTextControlMultiLine.h:
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::baselinePosition const): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLBlock.h:
Canonical link: https://commits.webkit.org/297522@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
