Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7662e19b5067d6aaf626101e3a971ca44234fcc5
https://github.com/WebKit/WebKit/commit/7662e19b5067d6aaf626101e3a971ca44234fcc5
Author: Sammy Gill <sammy.g...@apple.com>
Date: 2025-07-15 (Tue, 15 Jul 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-flex-003-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-flex-004-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-flex-003-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-flex-004-expected.txt
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[Flex][Baseline Alignment] Alignment candidate should consider both first and
last baseline item position.
https://bugs.webkit.org/show_bug.cgi?id=295908
rdar://155806707
Reviewed by Alan Baradlay.
In order to determine the flex item that should represent the flexbox's
baseline the spec has a specific set of steps. The first step is:
"If any of the flex items on the flex container’s startmost/endmost flex
line participate in baseline alignment, the flex container’s first/last
main-axis baseline set is generated from the shared alignment baseline
of those flex items."
We call into {first, last}BaselineCandidateOnLine to see if any of the
flex items meet this criterion by, among other things, seeing if the
item's alignment is first baseline for firstBaselineCandidateOnLine and
last baseline for lastBaselineCandidateOnLine. However, it seems like we
should be considering both values in both functions since in both cases
these items do participate in baseline alignment and just submit
different baselines for their alignment.
https://drafts.csswg.org/css-flexbox-1/#flex-baselines
https://drafts.csswg.org/css-flexbox-1/#baseline-participation
Canonical link: https://commits.webkit.org/297402@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
