Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1bd6d04e39cfeb71aa4fce42bc25a3c2f0cad9f
      
https://github.com/WebKit/WebKit/commit/a1bd6d04e39cfeb71aa4fce42bc25a3c2f0cad9f
  Author: Vassili Bykov <[email protected]>
  Date:   2025-07-11 (Fri, 11 Jul 2025)

  Changed paths:
    M Source/JavaScriptCore/API/tests/testapi.cpp
    M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

  Log Message:
  -----------
  CLoop::execute frame size is unreasonably large in debug builds, causing a 
testapi failure
https://bugs.webkit.org/show_bug.cgi?id=295796
rdar://155633380

Reviewed by Yusuke Suzuki and Mark Lam.

std::bit_cast compiled at -O0 optimization level introduces a stack frame slot 
for each call site.
The generated code in CLoop::execute has a large number of such call sites, 
resulting in a huge
stack frame. This causes a stack overflow in one of the testapi tests, running 
which requires 3
nested calls to CLoop::execute.

The patch replaces std::bit_cast with static_cast and reinterpret_cast as 
appropriate.

* Source/JavaScriptCore/API/tests/testapi.cpp:
(TestAPI::proxyReturnedWithJSSubclassing):
* Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):

Canonical link: https://commits.webkit.org/297283@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to