Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 51479c6a8c390745bdf401d50a4d0af1134fc739
https://github.com/WebKit/WebKit/commit/51479c6a8c390745bdf401d50a4d0af1134fc739
Author: BJ Burg <[email protected]>
Date: 2025-07-10 (Thu, 10 Jul 2025)
Changed paths:
M Source/JavaScriptCore/inspector/remote/RemoteInspector.h
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/inspector/InspectorBackendClient.h
R Source/WebCore/inspector/InspectorClient.h
M Source/WebCore/inspector/InspectorController.cpp
M Source/WebCore/inspector/InspectorController.h
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/inspector/InspectorOverlay.h
M Source/WebCore/inspector/WorkerInspectorController.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
M Source/WebCore/inspector/agents/InspectorPageAgent.h
M Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp
M Source/WebCore/inspector/agents/page/PageNetworkAgent.h
M Source/WebCore/inspector/agents/page/PageTimelineAgent.cpp
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/PageConfiguration.cpp
M Source/WebCore/page/PageConfiguration.h
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Sources.txt
M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp
M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h
M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in
M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebProcess/Inspector/WebInspectorBackendClient.cpp
A Source/WebKit/WebProcess/Inspector/WebInspectorBackendClient.h
M Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp
R Source/WebKit/WebProcess/Inspector/WebInspectorClient.h
M Source/WebKit/WebProcess/Inspector/WebInspectorInternal.cpp
M Source/WebKit/WebProcess/Inspector/WebInspectorInternal.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h
M Source/WebKitLegacy/mac/WebView/WebView.mm
Log Message:
-----------
Web Inspector: rename InspectorClient to InspectorBackendClient in WebCore
https://bugs.webkit.org/show_bug.cgi?id=295727
Reviewed by Timothy Hatcher.
In WebCore code, we now have similarly named InspectorFrontendClient and
InspectorBackendClient
for each Page. This renaming aligns with recent changes to split apart the IPC
interfaces for Inspector
frontend and backend.
This change avoids renaming WebKitLegacy classes because WebInspectorClient is
both
a frontend and backend client in the single process model.
No new tests, no behavior change.
* Source/JavaScriptCore/inspector/remote/RemoteInspector.h:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/InspectorBackendClient.h: Renamed from
Source/WebCore/inspector/InspectorClient.h.
(WebCore::InspectorBackendClient::frontendCountChanged):
(WebCore::InspectorBackendClient::didResizeMainFrame):
(WebCore::InspectorBackendClient::showInspectorIndication):
(WebCore::InspectorBackendClient::hideInspectorIndication):
(WebCore::InspectorBackendClient::overridesShowPaintRects const):
(WebCore::InspectorBackendClient::setShowPaintRects):
(WebCore::InspectorBackendClient::showPaintRect):
(WebCore::InspectorBackendClient::paintRectCount const):
(WebCore::InspectorBackendClient::didSetSearchingForNode):
(WebCore::InspectorBackendClient::elementSelectionChanged):
(WebCore::InspectorBackendClient::timelineRecordingChanged):
(WebCore::InspectorBackendClient::setDeveloperPreferenceOverride):
(WebCore::InspectorBackendClient::setEmulatedConditions):
(WebCore::InspectorBackendClient::allowRemoteInspectionToPageDirectly const):
* Source/WebCore/inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::createLazyAgents):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::disconnectAllFrontends):
(WebCore::InspectorController::show):
(WebCore::InspectorController::paintRectCount const):
(WebCore::InspectorController::setIndicating):
(WebCore::InspectorController::ensurePageAgent):
* Source/WebCore/inspector/InspectorController.h:
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
* Source/WebCore/inspector/InspectorOverlay.h:
* Source/WebCore/inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::updateServiceWorkerPageFrontendCount):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setSearchingForNode):
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::overrideSetting):
* Source/WebCore/inspector/agents/InspectorPageAgent.h:
* Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp:
(WebCore::PageNetworkAgent::PageNetworkAgent):
* Source/WebCore/inspector/agents/page/PageNetworkAgent.h:
* Source/WebCore/inspector/agents/page/PageTimelineAgent.cpp:
(WebCore::PageTimelineAgent::internalStart):
(WebCore::PageTimelineAgent::internalStop):
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scheduleResizeEventIfNeeded):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
(WebCore::m_presentingApplicationBundleIdentifier):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/PageConfiguration.cpp:
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/testing/Internals.cpp:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:
(WebKit::WebInspectorUIProxy::setDeveloperPreferenceOverride):
* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in:
* Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp:
(WebKit::WebPageInspectorController::disconnectAllFrontends):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Inspector/WebInspectorBackendClient.cpp: Copied from
Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp.
(WebKit::WebInspectorBackendClient::WebInspectorBackendClient):
(WebKit::WebInspectorBackendClient::~WebInspectorBackendClient):
(WebKit::WebInspectorBackendClient::inspectedPageDestroyed):
(WebKit::WebInspectorBackendClient::frontendCountChanged):
(WebKit::WebInspectorBackendClient::openLocalFrontend):
(WebKit::WebInspectorBackendClient::bringFrontendToFront):
(WebKit::WebInspectorBackendClient::didResizeMainFrame):
(WebKit::WebInspectorBackendClient::highlight):
(WebKit::WebInspectorBackendClient::hideHighlight):
(WebKit::WebInspectorBackendClient::showPaintRect):
(WebKit::WebInspectorBackendClient::animationEndedForLayer):
(WebKit::WebInspectorBackendClient::showInspectorIndication):
(WebKit::WebInspectorBackendClient::hideInspectorIndication):
(WebKit::WebInspectorBackendClient::didSetSearchingForNode):
(WebKit::WebInspectorBackendClient::elementSelectionChanged):
(WebKit::WebInspectorBackendClient::timelineRecordingChanged):
(WebKit::WebInspectorBackendClient::setDeveloperPreferenceOverride):
(WebKit::WebInspectorBackendClient::setEmulatedConditions):
(WebKit::WebInspectorBackendClient::willMoveToPage):
(WebKit::WebInspectorBackendClient::didMoveToPage):
(WebKit::WebInspectorBackendClient::drawRect):
(WebKit::WebInspectorBackendClient::mouseEvent):
* Source/WebKit/WebProcess/Inspector/WebInspectorBackendClient.h: Renamed from
Source/WebKit/WebProcess/Inspector/WebInspectorClient.h.
* Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp:
(WebKit::WebInspectorBackendClient::WebInspectorBackendClient):
(WebKit::WebInspectorBackendClient::~WebInspectorBackendClient):
(WebKit::WebInspectorBackendClient::inspectedPageDestroyed):
(WebKit::WebInspectorBackendClient::frontendCountChanged):
(WebKit::WebInspectorBackendClient::openLocalFrontend):
(WebKit::WebInspectorBackendClient::bringFrontendToFront):
(WebKit::WebInspectorBackendClient::didResizeMainFrame):
(WebKit::WebInspectorBackendClient::highlight):
(WebKit::WebInspectorBackendClient::hideHighlight):
(WebKit::WebInspectorBackendClient::showPaintRect):
(WebKit::WebInspectorBackendClient::animationEndedForLayer):
(WebKit::WebInspectorBackendClient::showInspectorIndication):
(WebKit::WebInspectorBackendClient::hideInspectorIndication):
(WebKit::WebInspectorBackendClient::didSetSearchingForNode):
(WebKit::WebInspectorBackendClient::elementSelectionChanged):
(WebKit::WebInspectorBackendClient::timelineRecordingChanged):
(WebKit::WebInspectorBackendClient::setDeveloperPreferenceOverride):
(WebKit::WebInspectorBackendClient::setEmulatedConditions):
(WebKit::WebInspectorBackendClient::willMoveToPage):
(WebKit::WebInspectorBackendClient::didMoveToPage):
(WebKit::WebInspectorBackendClient::drawRect):
(WebKit::WebInspectorBackendClient::mouseEvent):
(WebKit::WebInspectorClient::WebInspectorClient): Deleted.
(WebKit::WebInspectorClient::~WebInspectorClient): Deleted.
(WebKit::WebInspectorClient::inspectedPageDestroyed): Deleted.
(WebKit::WebInspectorClient::frontendCountChanged): Deleted.
(WebKit::WebInspectorClient::openLocalFrontend): Deleted.
(WebKit::WebInspectorClient::bringFrontendToFront): Deleted.
(WebKit::WebInspectorClient::didResizeMainFrame): Deleted.
(WebKit::WebInspectorClient::highlight): Deleted.
(WebKit::WebInspectorClient::hideHighlight): Deleted.
(WebKit::WebInspectorClient::showPaintRect): Deleted.
(WebKit::WebInspectorClient::animationEndedForLayer): Deleted.
(WebKit::WebInspectorClient::showInspectorIndication): Deleted.
(WebKit::WebInspectorClient::hideInspectorIndication): Deleted.
(WebKit::WebInspectorClient::didSetSearchingForNode): Deleted.
(WebKit::WebInspectorClient::elementSelectionChanged): Deleted.
(WebKit::WebInspectorClient::timelineRecordingChanged): Deleted.
(WebKit::WebInspectorClient::setDeveloperPreferenceOverride): Deleted.
(WebKit::WebInspectorClient::setEmulatedConditions): Deleted.
(WebKit::WebInspectorClient::willMoveToPage): Deleted.
(WebKit::WebInspectorClient::didMoveToPage): Deleted.
(WebKit::WebInspectorClient::drawRect): Deleted.
(WebKit::WebInspectorClient::mouseEvent): Deleted.
* Source/WebKit/WebProcess/Inspector/WebInspectorInternal.cpp:
(WebKit::WebInspector::setDeveloperPreferenceOverride):
* Source/WebKit/WebProcess/Inspector/WebInspectorInternal.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Canonical link: https://commits.webkit.org/297246@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
