Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 03eba551b315785466c30c67be0dba1fcb3e1962
https://github.com/WebKit/WebKit/commit/03eba551b315785466c30c67be0dba1fcb3e1962
Author: Lily Spiniolas <[email protected]>
Date: 2025-07-01 (Tue, 01 Jul 2025)
Changed paths:
M LayoutTests/TestExpectations
A
LayoutTests/fast/forms/form-control-refresh/button-like-controls-text-color-matches-expected.txt
A
LayoutTests/fast/forms/form-control-refresh/button-like-controls-text-color-matches.html
A
LayoutTests/fast/forms/form-control-refresh/submit-button-appearance-matches-button-window-inactive-expected.html
A
LayoutTests/fast/forms/form-control-refresh/submit-button-appearance-matches-button-window-inactive.html
A
LayoutTests/fast/forms/form-control-refresh/submit-button-text-color-disabled-state-expected.html
A
LayoutTests/fast/forms/form-control-refresh/submit-button-text-color-disabled-state.html
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/TextPaintStyle.cpp
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h
Log Message:
-----------
[Form control refresh] Text/decoration colors are incorrect for button-like
controls in certain cases
https://bugs.webkit.org/show_bug.cgi?id=295170
rdar://153937240
Reviewed by Abrar Rahman Protyasha.
* The text for disabled submit buttons now uses tertiary label color
when the window is active, and matches the text color of normal
buttons when the window is inactive. This is achieved by setting
a new style flag `insideDisabledSubmitButton` when appropriate during
style adjustment. This flag is checked for during text painting, and
when present, the text color is adjusted as necessary.
* For <select> buttons and non-submit buttons, tint color is no longer
used as the text color or decoration color on any platform.
* The text/decoration color of <select> buttons now matches the
color of typical buttons.
* When the Form control refresh is supported, clicking a button or otherwise
using CSS value "ActiveButtonText" no longer creates a `NSButtonCell` in
order to determine the text color to use. Instead, the typical button text
color is used.
* LayoutTests/TestExpectations:
*
LayoutTests/fast/forms/form-control-refresh/button-like-controls-text-color-matches-expected.txt:
Added.
*
LayoutTests/fast/forms/form-control-refresh/button-like-controls-text-color-matches.html:
Added.
*
LayoutTests/fast/forms/form-control-refresh/submit-button-appearance-matches-button-window-inactive-expected.html:
Added.
*
LayoutTests/fast/forms/form-control-refresh/submit-button-appearance-matches-button-window-inactive.html:
Added.
*
LayoutTests/fast/forms/form-control-refresh/submit-button-text-color-disabled-state-expected.html:
Added.
*
LayoutTests/fast/forms/form-control-refresh/submit-button-text-color-disabled-state.html:
Added.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::disabledSubmitButtonTextColor const):
* Source/WebCore/rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustMenuListStyleForVectorBasedControls const):
(WebCore::RenderThemeCocoa::buttonTextColor const):
(WebCore::RenderThemeCocoa::adjustButtonStyleForVectorBasedControls const):
(WebCore::RenderThemeCocoa::adjustMenuListButtonStyleForVectorBasedControls
const):
(WebCore::RenderThemeCocoa::paintMenuListButtonDecorationsForVectorBasedControls):
(WebCore::RenderThemeCocoa::disabledSubmitButtonTextColor const):
(WebCore::adjustButtonLikeControlStyleForVectorBasedControls): Deleted.
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::rareInheritedDataChangeRequiresRepaint):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::insideDisabledSubmitButton const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setInsideDisabledSubmitButton):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
(WebCore::StyleRareInheritedData::dumpDifferences const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
Canonical link: https://commits.webkit.org/296886@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
