Branch: refs/heads/webkitglib/2.46
Home: https://github.com/WebKit/WebKit
Commit: 45762748e5f4cf63e0144c42106426b46770dc6e
https://github.com/WebKit/WebKit/commit/45762748e5f4cf63e0144c42106426b46770dc6e
Author: Philippe Normand <[email protected]>
Date: 2025-06-27 (Fri, 27 Jun 2025)
Changed paths:
M
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
Log Message:
-----------
Cherry-pick 294886@main (58dae86e4a98).
https://bugs.webkit.org/show_bug.cgi?id=292924
[GStreamer][MediaStream] Reference cycle in webkitmediastreamsrc preventing
its disposal
https://bugs.webkit.org/show_bug.cgi?id=292924
Reviewed by Xabier Rodriguez-Calvar.
The src pad probe data storing a strong reference of the src element
introduced a reference cycle,
so use a weak reference instead.
Also, remove a useless refcount increment/decrement in
webkitMediaStreamSrcEnsureStreamCollectionPosted, the
callOnMainThreadAndWait call is blocking so
there is no need to increase the element refcount before calling the
closure.
*
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcEnsureStreamCollectionPosted):
(webkitMediaStreamSrcPadProbeCb):
(webkitMediaStreamSrcAddTrack):
Canonical link: https://commits.webkit.org/294886@main
Canonical link: https://commits.webkit.org/282416.493@webkitglib/2.46
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
