Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ae55be289fbe0881e10b5d1c5f3a35b2474583a
https://github.com/WebKit/WebKit/commit/5ae55be289fbe0881e10b5d1c5f3a35b2474583a
Author: Brady Eidson <[email protected]>
Date: 2025-06-25 (Wed, 25 Jun 2025)
Changed paths:
M Source/WebCore/editing/cocoa/AutofillElements.cpp
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/FocusController.h
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Source/WebKitLegacy/mac/DOM/DOM.mm
Log Message:
-----------
Refactor common FocusController code path to be site-isolation aware
rdar://154258045
https://bugs.webkit.org/show_bug.cgi?id=294951
Reviewed by Ryosuke Niwa.
To prepare for making "advancing focus" to be able to cross frame boundaries
with site isolation enabled,
this patch refactors the relevant code path of FocusController to include more
context about an attempted
focus operation.
With site isolation disabled, this doesn't change behavior.
With site isolation enabled, you'll see the added log statements fire when you
try certain operations into
an isolated iframe.
* Source/WebCore/editing/cocoa/AutofillElements.cpp:
(WebCore::nextAutofillableElement):
(WebCore::previousAutofillableElement):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementDescendingIntoSubframes):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementWithinScope):
(WebCore::FocusController::nextFocusableElementWithinScope):
(WebCore::FocusController::previousFocusableElementWithinScope):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::shouldClearSelectionWhenChangingFocusedElement):
(WebCore::updateFocusCandidateIfNeeded):
* Source/WebCore/page/FocusController.h:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::nextAssistableElement):
* Source/WebKitLegacy/mac/DOM/DOM.mm:
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
Canonical link: https://commits.webkit.org/296625@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
