Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f3a0304bc66ce5f06298cab648e3adbe4ebd596f
https://github.com/WebKit/WebKit/commit/f3a0304bc66ce5f06298cab648e3adbe4ebd596f
Author: Jer Noble <[email protected]>
Date: 2025-06-13 (Fri, 13 Jun 2025)
Changed paths:
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm
Log Message:
-----------
[macOS] Unable to pause video playback in PiP mode
rdar://152192112
https://bugs.webkit.org/show_bug.cgi?id=294449
Reviewed by Eric Carlson.
>From logging, it appears that the playback state of the WebContent process is
>becoming
out-of-sync with the cached playback state in the UIProcess. Without knowing
exactly how
this synchronization failed, work around the issue by explicitly updating the
cached
playback state whenever a play() or pause() command is issued by the UIProcess.
* Source/WebCore/platform/cocoa/PlaybackSessionModel.h:
(WTF::LogArgument<OptionSet<WebCore::PlaybackSessionModel::PlaybackState>>::toString):
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::updateForEventName):
(WebCore::PlaybackSessionModelMediaElement::play):
(WebCore::PlaybackSessionModelMediaElement::pause):
(WebCore::PlaybackSessionModelMediaElement::updateRate):
* Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:
(WebCore::PlaybackSessionInterfaceMac::rateChanged):
* Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm:
(WebCore::VideoPresentationInterfaceMac::rateChanged):
Canonical link: https://commits.webkit.org/296219@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
