Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7352a31480b4fc94cc59024673214114118a5752
https://github.com/WebKit/WebKit/commit/7352a31480b4fc94cc59024673214114118a5752
Author: Alan Baradlay <za...@apple.com>
Date: 2025-06-04 (Wed, 04 Jun 2025)
Changed paths:
A LayoutTests/fast/inline/list-item-marker-with-empty-list-expected.html
A LayoutTests/fast/inline/list-item-marker-with-empty-list.html
M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
Log Message:
-----------
v8.dev: wrong height for span in grid listing
https://bugs.webkit.org/show_bug.cgi?id=293179
<rdar://problem/151655455>
Reviewed by Antti Koivisto.
Do not dismiss empty block containers as list marker parent candidates.
In findParentOfEmptyOrFirstLineBox, we travers the list item's subtree to find
an insertion position for the list marker.
While the first block container with inline content is the preferred insertion
point,
skipping empty block containers results in constructing anonymous block parent.
(inline level list marker next to (empty) block level container)
We should also consider block containers with inline boxes even when they
do not generate visible content (e.g. <div><span></span></div>).
This patch introduces the concept of 'fallback parent' which is used when
no candidate with inline content is found.
* LayoutTests/fast/inline/list-item-marker-with-empty-list-expected.html: Added.
* LayoutTests/fast/inline/list-item-marker-with-empty-list.html: Added.
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
(WebCore::parentCandidateForMarker):
(WebCore::RenderTreeBuilder::List::updateItemMarker):
(WebCore::getParentOfFirstLineBox): Deleted.
Canonical link: https://commits.webkit.org/295819@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
