Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1243db2d3cef54f8258b2ace6c8dd71476efe8c7
      
https://github.com/WebKit/WebKit/commit/1243db2d3cef54f8258b2ace6c8dd71476efe8c7
  Author: Richard Robinson <[email protected]>
  Date:   2025-06-02 (Mon, 02 Jun 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M 
Source/WebKit/WebKitSwift/WritingTools/IntelligenceTextEffectViewManager.swift
    M 
Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift
    M 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.h
    M 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.swift
    M 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.h
    M 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.swift
    M 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.h

  Log Message:
  -----------
  [Swift in WebKit] The Swift implementation of intelligence text effects code 
is slightly incorrect
https://bugs.webkit.org/show_bug.cgi?id=293856
rdar://152373241

Reviewed by Aditya Keerthi.

Properly use `@objc @implementation` and address all the errors it exposes.

Also apply formatting and linting.

* 
Source/WebKit/WebKitSwift/WritingTools/IntelligenceTextEffectViewManager.swift:
* 
Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift:
* 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.swift:
* 
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.swift:
* Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.h:

- Format code
- Remove needless `public`
- Replace force-unwrap with optional-unwrap
- Justify other force-unwraps

Canonical link: https://commits.webkit.org/295726@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to