Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 590a90ef44375b0f8b15d43f54411f44e58ec7af
https://github.com/WebKit/WebKit/commit/590a90ef44375b0f8b15d43f54411f44e58ec7af
Author: Ada Chan <[email protected]>
Date: 2025-05-30 (Fri, 30 May 2025)
Changed paths:
M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/WebKitSwift/RealityKit/RKEntity.swift
M Source/WebKit/WebKitSwift/RealityKit/RealityKitBridging.h
Log Message:
-----------
Use the same EnvironmentResource instance for default lighting for all
entities in the Model process
https://bugs.webkit.org/show_bug.cgi?id=293781
rdar://152262994
Reviewed by Mike Wyrzykowski.
We don't need duplicate copies of the default EnvironmentResource for multiple
entities in the Model process. One instance can be shared across them, but we
cannot set up its attribution target to a Web Content process anymore, hence
removing the attributionHandler for the applyDefaultIBL() method.
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::ModelProcessModelPlayerProxy::applyDefaultIBL):
* Source/WebKit/WebKitSwift/RealityKit/RKEntity.swift:
(WKSRKEntity._defaultEnvironmentResource):
(WKSRKEntity.applyIBL(_:)):
New helper method for setting up the entity's lighting components.
(WKSRKEntity.applyIBL(_:attributionHandler:completion:)):
Adopt the new helper method.
(WKSRKEntity.applyDefaultIBL):
Use the default EnvironmentResource if it exists. If the default
EnvironmentResource has not been created yet, create it asynchronously
and apply the IBL back on the main thread.
(WKSRKEntity.applyDefaultIBL(_:)): Deleted.
* Source/WebKit/WebKitSwift/RealityKit/RealityKitBridging.h:
Canonical link: https://commits.webkit.org/295628@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
