Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6dea97203babea28f161316dfe9f8594262e8aea
https://github.com/WebKit/WebKit/commit/6dea97203babea28f161316dfe9f8594262e8aea
Author: Sammy Gill <sammy.g...@apple.com>
Date: 2025-05-21 (Wed, 21 May 2025)
Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp
A Source/WebCore/rendering/style/GridArea.cpp
A Source/WebCore/rendering/style/GridSpan.cpp
A Source/WebCore/rendering/style/GridSpan.h
Log Message:
-----------
[Grid] Stop using GridAxis in GridTrackSizingAlgorithm
https://bugs.webkit.org/show_bug.cgi?id=291010
rdar://148532926
Reviewed by Alan Baradlay.
This is the second patch in my stop using GridAxis in grid code series
of patches. See https://commits.webkit.org/292609@main for a detailed
explanation behind the reasoning.
In this patch we remove all uses in GridTrackSizingAlgorithm. Just like
in the first patch any uses of GridAxis::GridColumnAxis is replaced with
GridTrackSizingDirrection::ForRows and any uses of GridAxis::GridRowAxis
is replaced with GridTrackSizingAlgorithm::ForColumns. This also allows
us to stop using the temporary translation functions within RenderGrid.
Also change m_columnBaselineItemsMap to m_baselineAlignmentItemsForRows
and m_rowBaselineItemsMap to m_baselineAlignmentItemsForColumns to
better reflect the changes.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::isIntrinsicSizedGridArea const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForGridItem const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentContributionForGridItem
const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentContributionForGridItem
const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContributionForGridItem const):
(WebCore::GridTrackSizingAlgorithm::canParticipateInBaselineAlignment const):
(WebCore::GridTrackSizingAlgorithm::participateInBaselineAlignment const):
(WebCore::GridTrackSizingAlgorithm::updateBaselineAlignmentContext):
(WebCore::GridTrackSizingAlgorithm::baselineOffsetForGridItem const):
(WebCore::GridTrackSizingAlgorithm::clearBaselineItemsCache):
(WebCore::GridTrackSizingAlgorithm::cacheBaselineAlignedItem):
(WebCore::GridTrackSizingAlgorithm::copyBaselineItemsCache):
(WebCore::DefiniteSizeStrategy::minContentContributionForGridItem const):
(WebCore::GridTrackSizingAlgorithm::computeBaselineAlignmentContext):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::cacheBaselineAlignedGridItems):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::columnAxisBaselineOffsetForGridItem const):
(WebCore::RenderGrid::rowAxisBaselineOffsetForGridItem const):
Canonical link: https://commits.webkit.org/295252@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
