Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca5554a142fd1f3bbe12b7161113e5d8359dc534
https://github.com/WebKit/WebKit/commit/ca5554a142fd1f3bbe12b7161113e5d8359dc534
Author: Matt Woodrow <[email protected]>
Date: 2025-05-20 (Tue, 20 May 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-animations-expected.txt
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.h
M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.h
Log Message:
-----------
css/css-view-transitions/pseudo-element-animations fails to remove animations
when the document element gets display:none.
https://bugs.webkit.org/show_bug.cgi?id=293034
<rdar://151353389>
Reviewed by Tim Nguyen.
Setting display:none on the document element should remove the VT tree (and all
associated animations), but does not because the VT renderer tree is a sibling
of the document element's renderer.
Make sure RenderTreeUpdater explicitly clears the VT tree if the document
element renderer gets removed, and make sure we remove animations (on removed
renderers, and their descendants).
*
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-animations-expected.txt:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::clearViewTransition):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::destroyAndCancelAnimationsForSubtree):
* Source/WebCore/rendering/updating/RenderTreeUpdater.h:
* Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp:
(WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementTree):
(WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementGroup):
* Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.h:
Canonical link: https://commits.webkit.org/295170@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
