Title: [112691] trunk/Source/WebCore
Revision
112691
Author
sulli...@apple.com
Date
2012-03-30 11:00:41 -0700 (Fri, 30 Mar 2012)

Log Message

Certain emoji characters should not be displayed in user-visible URL strings.
<https://bugs.webkit.org/show_bug.cgi?id=82739>
<rdar://problem/9205643>

Reviewed by Alexey Proskuryakov

* platform/mac/WebCoreNSURLExtras.mm:
(WebCore::isLookalikeCharacter):
Added five emoji characters to the list.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (112690 => 112691)


--- trunk/Source/WebCore/ChangeLog	2012-03-30 17:54:03 UTC (rev 112690)
+++ trunk/Source/WebCore/ChangeLog	2012-03-30 18:00:41 UTC (rev 112691)
@@ -1,3 +1,15 @@
+2012-03-30  John Sullivan  <sulli...@apple.com>
+
+        Certain emoji characters should not be displayed in user-visible URL strings.
+        <https://bugs.webkit.org/show_bug.cgi?id=82739>
+        <rdar://problem/9205643>
+
+        Reviewed by Alexey Proskuryakov
+
+        * platform/mac/WebCoreNSURLExtras.mm:
+        (WebCore::isLookalikeCharacter):
+        Added five emoji characters to the list.
+
 2012-03-30  David Barr  <davidb...@chromium.org>
 
         Split up top-level .gitignore and .gitattributes

Modified: trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm (112690 => 112691)


--- trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm	2012-03-30 17:54:03 UTC (rev 112690)
+++ trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm	2012-03-30 18:00:41 UTC (rev 112691)
@@ -53,7 +53,7 @@
 {
     // This function treats the following as unsafe, lookalike characters:
     // any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, 
-    // and any ignorable character.
+    // any ignorable character, and emoji characters related to locks.
     
     // We also considered the characters in Mozilla's blacklist (http://kb.mozillazine.org/Network.IDN.blacklist_chars), 
     // and included all of these characters that ICU can encode.
@@ -103,6 +103,11 @@
         case 0xFE3F: /* PRESENTATION FORM FOR VERTICAL LEFT ANGLE BRACKET */
         case 0xFE5D: /* SMALL LEFT TORTOISE SHELL BRACKET */
         case 0xFE5E: /* SMALL RIGHT TORTOISE SHELL BRACKET */
+        case 0x1F50F: /* LOCK WITH INK PEN */
+        case 0x1F510: /* CLOSED LOCK WITH KEY */
+        case 0x1F511: /* KEY */
+        case 0x1F512: /* LOCK */
+        case 0x1F513: /* OPEN LOCK */
             return YES;
         default:
             return NO;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to