Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ac0a643535c3e12f0c341b56f36750851333b43c
https://github.com/WebKit/WebKit/commit/ac0a643535c3e12f0c341b56f36750851333b43c
Author: Youenn Fablet <[email protected]>
Date: 2025-05-13 (Tue, 13 May 2025)
Changed paths:
M Source/WebCore/platform/ScriptExecutionContextIdentifier.h
M Source/WebCore/workers/service/server/SWServer.cpp
Log Message:
-----------
SWServer::registerServiceWorkerClient is not clearing
m_clientIdentifiersPerOrigin identifiers list properly
https://bugs.webkit.org/show_bug.cgi?id=292866
rdar://150678359
Reviewed by Chris Dumez.
We were calling Vector::remove using a ScriptExecutionContextIdentifier which
was casted as a boolean to a size_t.
We were then removing a Vector entry based on a position and not based on the
value to remove.
We instead call removeFirst and make ScriptExecutionContextIdentifier bool
conversion explicit.
We add a debug ASSERT to catch potential removal mismatch in existing tests.
* Source/WebCore/platform/ScriptExecutionContextIdentifier.h:
(WebCore::ProcessQualified<WTF::UUID>::operator bool const):
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::registerServiceWorkerClient):
Canonical link: https://commits.webkit.org/294832@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
