Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3606cb0acd00c283e98f1c9db98a5d54ce9fe7ef
https://github.com/WebKit/WebKit/commit/3606cb0acd00c283e98f1c9db98a5d54ce9fe7ef
Author: Sam Weinig <[email protected]>
Date: 2025-05-11 (Sun, 11 May 2025)
Changed paths:
A LayoutTests/fast/canvas/font-line-height-normal-expected.txt
A LayoutTests/fast/canvas/font-line-height-normal.html
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumer.h
M
Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumerDefinitions.h
Log Message:
-----------
REGRESSION(288714@main): CanvasRenderingContext2D font with normal line
height fails to parse
https://bugs.webkit.org/show_bug.cgi?id=291667
rdar://149459999
Reviewed by Darin Adler.
Fixes regression in 288714@main that failed to parse the keyword `normal`
when parsing strings passed to `CanvasRenderingContext2D.font`.
The issue was due failing to include
CSSPropertyParserConsumer+KeywordDefinitions.h
in CSSPropertyParserConsumer+Font.cpp, which meant that the `MetaConsumer`
didn't have
a consumer for keyword values when being invoked in
`consumeLineHeightUnresolved`.
To ensure this kind of issue can't happen in the future, we now statically
assert
that all types passed to `MetaConsumer have `ConsumerDefinition` specializations
defined. Confirmed this works by just adding the assertion, which immediately
caused
the build to fail pointing directly to `consumeLineHeightUnresolved`.
* LayoutTests/fast/canvas/font-line-height-normal-expected.txt: Added.
* LayoutTests/fast/canvas/font-line-height-normal.html: Added.
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumer.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumerDefinitions.h:
Canonical link: https://commits.webkit.org/294767@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
