Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ee882e52c34012f37fcaf627a63b4a0bcfd1fd9
https://github.com/WebKit/WebKit/commit/6ee882e52c34012f37fcaf627a63b4a0bcfd1fd9
Author: Sammy Gill <[email protected]>
Date: 2025-05-10 (Sat, 10 May 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/rendering/FlexLineBuilder.cpp
R Source/WebCore/rendering/FlexLineBuilder.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
Log Message:
-----------
[Flex] Remove FlexLineBuilder and move code to RenderFlexibleBox.
https://bugs.webkit.org/show_bug.cgi?id=292800
rdar://151030980
Reviewed by Alan Baradlay.
FlexLineBuilder is a very small class that really only has one main
function, computeNextFlexLine, which computes which flex items are
supposed to be on the line along with some other flexing data. Other
than that there are a couple of small helper functions and a
definition for FlexLayoutItem which is heavily used by
RenderFlexibleBox. Since all of this is fairly small and self-contained
code we can just have it live inside RenderFlexibleBox.
In order to accomplish this, the main changes are:
1.) Move the definition of FlexLayoutItem to RenderFlexibleBox.cpp
2.) Move many of the helper functions to RenderFlexibleBox. Some code
is not needed anymore since they were just wrappers to functions in
RenderFlexibleBox (e.g. FlexLineBuilder::isMultiLine)
3.) Plumb in a couple of arguments to computeNextLine. We can probably
refactor this a bit more but this is a somewhat non-intrusive way in
order to just accomplish the code moving.
Canonical link: https://commits.webkit.org/294755@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
